feat: port of https://github.com/storacha/upload-service/commit/2c12c23d13d14e9f1b79c34b8169f20975d431f7 #1641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need a way to ensure users are redirected back to `https://bsky.storage` after completing the Stripe checkout process. To facilitate this, pass facts from `access/authorize` to`access/confirm` - users can now add a fact like `{app: 'bsky-backups'}` to `access/authorize`, which will tell the `access/confirm` handling code in `w3infra` to render the same pricing table we use on https://bsky.storage which sends the user back to that app after picking a plan via the email flow. Add support for this to the client code via a new `appName` option in the account creation functions that gets converted to a fact at the lowest level. There are a bunch of ways we could do this, but in the interest of shipping ASAP I think this is a reasonable and fast way to go. See storacha/w3infra#472 for the other part of this.
travis
approved these changes
May 21, 2025
This was referenced May 21, 2025
hannahhoward
pushed a commit
that referenced
this pull request
May 21, 2025
🤖 I have created a release *beep* *boop* --- ## [19.2.0](upload-api-v19.1.0...upload-api-v19.2.0) (2025-05-21) ### Features * port of storacha/upload-service@2c12c23 ([#1641](#1641)) ([8eb4306](8eb4306)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
hannahhoward
added a commit
that referenced
this pull request
May 21, 2025
🤖 I have created a release *beep* *boop* --- ## [17.3.0](w3up-client-v17.2.0...w3up-client-v17.3.0) (2025-05-21) ### Features * port of storacha/upload-service@2c12c23 ([#1641](#1641)) ([8eb4306](8eb4306)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hannah Howard <[email protected]>
hannahhoward
added a commit
that referenced
this pull request
May 21, 2025
🤖 I have created a release *beep* *boop* --- ## [20.3.0](access-v20.2.0...access-v20.3.0) (2025-05-21) ### Features * port of storacha/upload-service@2c12c23 ([#1641](#1641)) ([8eb4306](8eb4306)) ### Fixes * dedupe proofs ([#1635](#1635)) ([2ddb404](2ddb404)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hannah Howard <[email protected]>
hannahhoward
added a commit
to storacha/w3infra
that referenced
this pull request
May 21, 2025
If the `access/authorize` capability is invoked with `nb.app` set to `bsky-backups`, render the same pricing table we render on bsky.storage, which redirects them to that app rather than console.storacha.network after auth. See storacha/w3up#1641 for the other half of this. fix: move to facts fix: use facts --------- Co-authored-by: Travis Vachon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports over the upload api changes in the above commit to upload service
-- original commit message
feat: add
apptoaccess/authorizeandaccess/confirm(#264) (We need a way to ensure users are redirected back to
https://bsky.storageafter completing the Stripe checkout process.To facilitate this, pass facts from
access/authorizetoaccess/confirm- users can now add a fact like{app: 'bsky-backups'}toaccess/authorize, which will tell theaccess/confirmhandling code inw3infrato render the same pricing table we use on https://bsky.storage which sends the user back to that app after picking a plan via the email flow.Add support for this to the client code via a new
appNameoption in the account creation functions that gets converted to a fact at the lowest level.There are a bunch of ways we could do this, but in the interest of shipping ASAP I think this is a reasonable and fast way to go.
See storacha/w3infra#472 for the other part of this.