This repository was archived by the owner on Jun 29, 2025. It is now read-only.
feat(share): add share ID length setting #677
Merged
+45
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonith404
reviewed
Nov 21, 2024
romainricard
force-pushed
the
feat-share-add-shareid-length
branch
from
3dc8cdf to
18e3ce4
Compare
stonith404
reviewed
Nov 24, 2024
- Add share ID length to share > settings - Use cryptographically secure RNG for IDs - Use secure default value for IDs length - Add FR and EN translation
romainricard
force-pushed
the
feat-share-add-shareid-length
branch
from
18e3ce4 to
73730af
Compare
|
Now it looks good! Thanks for contributing to Pingvin Share :) |
stonith404
approved these changes
Nov 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
I'd like to be able to use a more robust share ID / share link when I share confidential files, regardless of password protection.
What this PR does
crypto.getRandomValuesis well-supported, and does not require a secure context (i.e. https), so it does not break when running locally/on a LAN without https.168 to be safe.Let me know if I need to change anything! ✨
Closes #613