Skip to content

Commit af0b6d0

Browse files
committed
Made version 2.1 of ZUGFeRD obsolete, will be removed in the next major version
1 parent 78aa304 commit af0b6d0

8 files changed

+87
-75
lines changed

ZUGFeRD-Test/BasicTests.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public void TestGetVersion()
103103

104104
path = @"..\..\..\..\demodata\zugferd21\zugferd_2p1_BASIC_Einfach-factur-x.xml";
105105
path = _makeSurePathIsCrossPlatformCompatible(path);
106-
Assert.AreEqual(InvoiceDescriptor.GetVersion(path), ZUGFeRDVersion.Version21);
106+
Assert.AreEqual(InvoiceDescriptor.GetVersion(path), ZUGFeRDVersion.Version22);
107107
} // !TestGetVersion()
108108
}
109109
}

ZUGFeRD-Test/ZUGFeRD21Tests.cs renamed to ZUGFeRD-Test/ZUGFeRD22Tests.cs

+59-56
Large diffs are not rendered by default.

ZUGFeRD/InvoiceDescriptor.cs

+14-14
Original file line numberDiff line numberDiff line change
@@ -330,16 +330,16 @@ public static ZUGFeRDVersion GetVersion(string filename)
330330
return ZUGFeRDVersion.Version1;
331331
}
332332

333-
reader = new InvoiceDescriptor21UblReader();
333+
reader = new InvoiceDescriptor22UblReader();
334334
if (reader.IsReadableByThisReaderVersion(filename))
335335
{
336-
return ZUGFeRDVersion.Version21;
336+
return ZUGFeRDVersion.Version22;
337337
}
338338

339-
reader = new InvoiceDescriptor21Reader();
339+
reader = new InvoiceDescriptor22Reader();
340340
if (reader.IsReadableByThisReaderVersion(filename))
341341
{
342-
return ZUGFeRDVersion.Version21;
342+
return ZUGFeRDVersion.Version22;
343343
}
344344

345345
reader = new InvoiceDescriptor20Reader();
@@ -369,16 +369,16 @@ public static ZUGFeRDVersion GetVersion(Stream stream)
369369
return ZUGFeRDVersion.Version1;
370370
}
371371

372-
reader = new InvoiceDescriptor21UblReader();
372+
reader = new InvoiceDescriptor22UblReader();
373373
if (reader.IsReadableByThisReaderVersion(stream))
374374
{
375-
return ZUGFeRDVersion.Version21;
375+
return ZUGFeRDVersion.Version22;
376376
}
377377

378-
reader = new InvoiceDescriptor21Reader();
378+
reader = new InvoiceDescriptor22Reader();
379379
if (reader.IsReadableByThisReaderVersion(stream))
380380
{
381-
return ZUGFeRDVersion.Version21;
381+
return ZUGFeRDVersion.Version22;
382382
}
383383

384384
reader = new InvoiceDescriptor20Reader();
@@ -409,13 +409,13 @@ public static InvoiceDescriptor Load(Stream stream)
409409
return reader.Load(stream);
410410
}
411411

412-
reader = new InvoiceDescriptor21UblReader();
412+
reader = new InvoiceDescriptor22UblReader();
413413
if (reader.IsReadableByThisReaderVersion(stream))
414414
{
415415
return reader.Load(stream);
416416
}
417417

418-
reader = new InvoiceDescriptor21Reader();
418+
reader = new InvoiceDescriptor22Reader();
419419
if (reader.IsReadableByThisReaderVersion(stream))
420420
{
421421
return reader.Load(stream);
@@ -448,13 +448,13 @@ public static InvoiceDescriptor Load(string filename)
448448
return reader.Load(filename);
449449
}
450450

451-
reader = new InvoiceDescriptor21UblReader();
451+
reader = new InvoiceDescriptor22UblReader();
452452
if (reader.IsReadableByThisReaderVersion(filename))
453453
{
454454
return reader.Load(filename);
455455
}
456456

457-
reader = new InvoiceDescriptor21Reader();
457+
reader = new InvoiceDescriptor22Reader();
458458
if (reader.IsReadableByThisReaderVersion(filename))
459459
{
460460
return reader.Load(filename);
@@ -882,8 +882,8 @@ private IInvoiceDescriptorWriter _selectInvoiceDescriptorWriter(ZUGFeRDVersion v
882882
return new InvoiceDescriptor1Writer();
883883
case ZUGFeRDVersion.Version20:
884884
return new InvoiceDescriptor20Writer();
885-
case ZUGFeRDVersion.Version21:
886-
return new InvoiceDescriptor21Writer();
885+
case ZUGFeRDVersion.Version22:
886+
return new InvoiceDescriptor22Writer();
887887
default:
888888
throw new UnsupportedException("New ZUGFeRDVersion '" + version + "' defined but not implemented!");
889889
}

ZUGFeRD/InvoiceDescriptor21Reader.cs renamed to ZUGFeRD/InvoiceDescriptor22Reader.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929
namespace s2industries.ZUGFeRD
3030
{
31-
internal class InvoiceDescriptor21Reader : IInvoiceDescriptorReader
31+
internal class InvoiceDescriptor22Reader : IInvoiceDescriptorReader
3232
{
3333
/// <summary>
3434
/// Parses the ZUGFeRD invoice from the given stream.

ZUGFeRD/InvoiceDescriptor21UblReader.cs renamed to ZUGFeRD/InvoiceDescriptor22UblReader.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929
namespace s2industries.ZUGFeRD
3030
{
31-
internal class InvoiceDescriptor21UblReader : IInvoiceDescriptorReader
31+
internal class InvoiceDescriptor22UblReader : IInvoiceDescriptorReader
3232
{
3333
/// <summary>
3434
/// Parses the ZUGFeRD invoice from the given stream.

ZUGFeRD/InvoiceDescriptor21Writer.cs renamed to ZUGFeRD/InvoiceDescriptor22Writer.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
namespace s2industries.ZUGFeRD
2929
{
30-
internal class InvoiceDescriptor21Writer : IInvoiceDescriptorWriter
30+
internal class InvoiceDescriptor22Writer : IInvoiceDescriptorWriter
3131
{
3232
private ProfileAwareXmlTextWriter Writer;
3333
private InvoiceDescriptor Descriptor;

ZUGFeRD/Profile.cs

+1
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ public static string EnumToString(this Profile profile, ZUGFeRDVersion version)
151151
default: throw new Exception("Unsupported profile for ZUGFeRD version 20");
152152
}
153153
case ZUGFeRDVersion.Version21:
154+
case ZUGFeRDVersion.Version22:
154155
switch (profile)
155156
{
156157
case Profile.Minimum: return "urn:factur-x.eu:1p0:minimum";

ZUGFeRD/ZUGFeRDVersion.cs

+9-1
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,21 @@ public enum ZUGFeRDVersion
3131
/// Version 1.x - first public ZUGFeRD version
3232
/// </summary>
3333
Version1 = 100,
34+
3435
/// <summary>
3536
/// Version 2.0 - second major ZUGFeRD version
3637
/// </summary>
3738
Version20 = 200,
39+
3840
/// <summary>
3941
/// Version 2.1 - unified with french factur-x 1.0, supports XRechnung
4042
/// </summary>
41-
Version21 = 210
43+
[Obsolete("Will be removed in the next version")]
44+
Version21 = 210,
45+
46+
/// <summary>
47+
/// Version 2.2 - unified with french factur-x 1.0, supports XRechnung
48+
/// </summary>
49+
Version22 = 220
4250
}
4351
}

0 commit comments

Comments
 (0)