fix: Update handling of trade charges and reason code serialization

lukasschachner · lukasschachner · commit 9112b0241b30 · 2025-04-03T21:28:17.000+02:00
Replaced `GetSpecifiedTradeAllowanceCharges` with `GetSpecifiedTradeCharges` to align with naming conventions. Updated reason code serialization method from `GetDescriptionAttribute` to `EnumToString` for improved clarity and consistency.
diff --git a/ZUGFeRD/InvoiceDescriptor22UBLWriter.cs b/ZUGFeRD/InvoiceDescriptor22UBLWriter.cs
@@ -654,13 +654,13 @@ private void _WriteTradeLineItem(TradeLineItem tradeLineItem, bool isInvoice = t
                 }
             }
 
-            foreach (var specifiedTradeAllowanceCharge in tradeLineItem.GetSpecifiedTradeAllowanceCharges())
+            foreach (var specifiedTradeAllowanceCharge in tradeLineItem.GetSpecifiedTradeCharges())
             {
                 Writer.WriteStartElement("cac", "AllowanceCharge");
                 Writer.WriteElementString("cbc", "ChargeIndicator",
                     specifiedTradeAllowanceCharge.ChargeIndicator ? "true" : "false"); // BG-28-0
                 Writer.WriteOptionalElementString("cbc", "AllowanceChargeReasonCode",
-                    specifiedTradeAllowanceCharge.ReasonCode.GetDescriptionAttribute()); // BT-140, BT-145
+                    specifiedTradeAllowanceCharge.ReasonCode.EnumToString()); // BT-140, BT-145
                 Writer.WriteOptionalElementString("cbc", "AllowanceChargeReason",
                     specifiedTradeAllowanceCharge.Reason); // BT-139, BT-144
 

Original file line number	Diff line number	Diff line change
`@@ -654,13 +654,13 @@ private void _WriteTradeLineItem(TradeLineItem tradeLineItem, bool isInvoice = t`
`654`	`654`	`}`
`655`	`655`	`}`
`656`	`656`
`657`		`- foreach (var specifiedTradeAllowanceCharge in tradeLineItem.GetSpecifiedTradeAllowanceCharges())`
	`657`	`+ foreach (var specifiedTradeAllowanceCharge in tradeLineItem.GetSpecifiedTradeCharges())`
`658`	`658`	`{`
`659`	`659`	`Writer.WriteStartElement("cac", "AllowanceCharge");`
`660`	`660`	`Writer.WriteElementString("cbc", "ChargeIndicator",`
`661`	`661`	`specifiedTradeAllowanceCharge.ChargeIndicator ? "true" : "false"); // BG-28-0`
`662`	`662`	`Writer.WriteOptionalElementString("cbc", "AllowanceChargeReasonCode",`
`663`		`- specifiedTradeAllowanceCharge.ReasonCode.GetDescriptionAttribute()); // BT-140, BT-145`
	`663`	`+ specifiedTradeAllowanceCharge.ReasonCode.EnumToString()); // BT-140, BT-145`
`664`	`664`	`Writer.WriteOptionalElementString("cbc", "AllowanceChargeReason",`
`665`	`665`	`specifiedTradeAllowanceCharge.Reason); // BT-139, BT-144`
`666`	`666`