Skip to content

Commit 50e5c61

Browse files
Fixed the possibility of using uninitialized variable in route_check.py (sonic-net#1551)
1 parent 5976399 commit 50e5c61

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

scripts/route_check.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -390,6 +390,8 @@ def check_routes():
390390
rt_asic_miss = []
391391

392392
results = {}
393+
adds = []
394+
deletes = []
393395

394396
selector, subs, rt_asic = get_route_entries()
395397

@@ -431,8 +433,8 @@ def check_routes():
431433
if results:
432434
print_message(syslog.LOG_WARNING, "Failure results: {", json.dumps(results, indent=4), "}")
433435
print_message(syslog.LOG_WARNING, "Failed. Look at reported mismatches above")
434-
print_message(syslog.LOG_WARNING, "add: {", json.dumps(adds, indent=4), "}")
435-
print_message(syslog.LOG_WARNING, "del: {", json.dumps(deletes, indent=4), "}")
436+
print_message(syslog.LOG_WARNING, "add: ", json.dumps(adds, indent=4))
437+
print_message(syslog.LOG_WARNING, "del: ", json.dumps(deletes, indent=4))
436438
return -1, results
437439
else:
438440
print_message(syslog.LOG_INFO, "All good!")

0 commit comments

Comments
 (0)