Fix 'show platform eeprom' on virtual switch (sonic-net#794)

borys-karpliak · web-flow · commit 1fc2c3d880e6 · 2020-02-04T15:02:11.000-08:00
add kvm to platforms which do not support syseeprom db and check for the 'read_syseeprom_db' method availibilty to avoid same issue on other platforms
diff --git a/scripts/decode-syseeprom b/scripts/decode-syseeprom
@@ -36,9 +36,6 @@ def main():
 
     platform_path = '/'.join([PLATFORM_ROOT, platform])
 
-    # Currently, don't support eeprom db on Arista platform
-    if 'arista' in platform_path:
-        support_eeprom_db = False
     #
     # Currently we only support board eeprom decode.
     #
@@ -55,6 +52,12 @@ def main():
     class_ = getattr(m, 'board')
     t = class_('board', '','','')
 
+    # Currently, don't support eeprom db on Arista platform
+    platforms_without_eeprom_db = ['arista', 'kvm']
+    if any(platform in platform_path for platform in platforms_without_eeprom_db)\
+            or t.getattr('read_eeprom_db', None) == None:
+        support_eeprom_db = False
+
     #
     # execute the command
     #

Original file line number	Diff line number	Diff line change
`@@ -36,9 +36,6 @@ def main():`
`36`	`36`
`37`	`37`	`platform_path = '/'.join([PLATFORM_ROOT, platform])`
`38`	`38`
`39`		`- # Currently, don't support eeprom db on Arista platform`
`40`		`- if 'arista' in platform_path:`
`41`		`- support_eeprom_db = False`
`42`	`39`	`#`
`43`	`40`	`# Currently we only support board eeprom decode.`
`44`	`41`	`#`
`@@ -55,6 +52,12 @@ def main():`
`55`	`52`	`class_ = getattr(m, 'board')`
`56`	`53`	`t = class_('board', '','','')`
`57`	`54`
	`55`	`+ # Currently, don't support eeprom db on Arista platform`
	`56`	`+ platforms_without_eeprom_db = ['arista', 'kvm']`
	`57`	`+ if any(platform in platform_path for platform in platforms_without_eeprom_db)\`
	`58`	`+ or t.getattr('read_eeprom_db', None) == None:`
	`59`	`+ support_eeprom_db = False`
	`60`	`+`
`58`	`61`	`#`
`59`	`62`	`# execute the command`
`60`	`63`	`#`