Skip to content

Changing screenshot algorithm from md5 to sha256 will allow compiler to run in FIPS-180-3 Compliant build containers #6241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ujas-sidapara opened this issue Apr 15, 2025 · 2 comments

Comments

@ujas-sidapara
Copy link
Contributor

Change request:

Can we make a change here:

const currentImageHash = createHash('md5').update(currentScreenshotBuf).digest('hex');

from md5 to sha256 as md5 is not available in environments that need FIPS compliance (or have restrictions against older hash functions with collision risks)

I'm happy to raise a PR for this change if accepted

@ujas-sidapara
Copy link
Contributor Author

@christian-bromann
Copy link
Member

@ujas-sidapara the change looks good, can you raise a PR to this repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants