Skip to content

Commit bb6c594

Browse files
authored
Add txHash field to getTransaction after upstream merge (#314)
1 parent 5932852 commit bb6c594

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

cmd/soroban-rpc/internal/methods/get_transaction.go

+1
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ func GetTransaction(
100100
OldestLedger: storeRange.FirstLedger.Sequence,
101101
OldestLedgerCloseTime: storeRange.FirstLedger.CloseTime,
102102
}
103+
response.TransactionHash = request.Hash
103104
if errors.Is(err, db.ErrNoTransaction) {
104105
response.Status = TransactionStatusNotFound
105106
return response, nil

cmd/soroban-rpc/internal/methods/get_transaction_test.go

+6-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ func TestGetTransaction(t *testing.T) {
3737
require.NoError(t, err)
3838
require.Equal(t, GetTransactionResponse{
3939
TransactionDetails: TransactionDetails{
40-
Status: TransactionStatusNotFound,
40+
Status: TransactionStatusNotFound,
41+
TransactionHash: hash,
4142
},
4243
}, tx)
4344

@@ -64,6 +65,7 @@ func TestGetTransaction(t *testing.T) {
6465
Status: TransactionStatusSuccess,
6566
ApplicationOrder: 1,
6667
FeeBump: false,
68+
TransactionHash: hash,
6769
EnvelopeXDR: expectedEnvelope,
6870
ResultXDR: expectedTxResult,
6971
ResultMetaXDR: expectedTxMeta,
@@ -88,6 +90,7 @@ func TestGetTransaction(t *testing.T) {
8890
TransactionDetails: TransactionDetails{
8991
Status: TransactionStatusSuccess,
9092
ApplicationOrder: 1,
93+
TransactionHash: hash,
9194
FeeBump: false,
9295
EnvelopeXDR: expectedEnvelope,
9396
ResultXDR: expectedTxResult,
@@ -120,6 +123,7 @@ func TestGetTransaction(t *testing.T) {
120123
Status: TransactionStatusFailed,
121124
ApplicationOrder: 1,
122125
FeeBump: false,
126+
TransactionHash: hash,
123127
EnvelopeXDR: expectedEnvelope,
124128
ResultXDR: expectedTxResult,
125129
ResultMetaXDR: expectedTxMeta,
@@ -155,6 +159,7 @@ func TestGetTransaction(t *testing.T) {
155159
Status: TransactionStatusSuccess,
156160
ApplicationOrder: 1,
157161
FeeBump: false,
162+
TransactionHash: hash,
158163
EnvelopeXDR: expectedEnvelope,
159164
ResultXDR: expectedTxResult,
160165
ResultMetaXDR: expectedTxMeta,

0 commit comments

Comments
 (0)