Skip to content

Post parallel ledger close cleanup #4592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 4 tasks
Tracked by #4318
marta-lokhova opened this issue Dec 19, 2024 · 0 comments · May be fixed by #4725
Open
1 of 4 tasks
Tracked by #4318

Post parallel ledger close cleanup #4592

marta-lokhova opened this issue Dec 19, 2024 · 0 comments · May be fixed by #4725
Assignees
Labels
cleanup refactoring or other internal improvements

Comments

@marta-lokhova
Copy link
Contributor

marta-lokhova commented Dec 19, 2024

To do after #4543 is landed (opening a separate issue to reduce the scope of this PR as per discussion with @graydon):

  • Audit gRandomEngine multi-threaded access
  • Rename CatchupManager -> ApplyExternalizedLedgersManager
  • Enforce that only one thread can reference an active LedgerTxn at all times. Add comment to LedgerTxn class saying it can only be used at apply time, everyone else should resort to read-only LedgerSnapshot class.
  • Remove LM from valueExternalized flow in Herder. Herder should go directly to LedgerApplyManager, since it is the module that handles applying now.
@marta-lokhova marta-lokhova added the cleanup refactoring or other internal improvements label Dec 19, 2024
@marta-lokhova marta-lokhova self-assigned this Dec 19, 2024
@marta-lokhova marta-lokhova linked a pull request May 12, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup refactoring or other internal improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant