Migrate movieByURL to groupByURL #2368
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah i missed some scraper changes... will have a look now |
|
stashapp/stash#5793 was merged into develop, but it will only be released in v0.29.0 build, so this PR should be delayed until then. |
|
Will also be a major breaking change, might be worth leaving a branch on moviesbyurl |
|
Mentioned in Discourse https://discourse.stashapp.cc/t/communityscrapers-master-branch-breaking-change/2058 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scraper type(s)
Examples to test
Short description
Now that stashapp/stash#5793 is complete, I think that this migration can now be done? I guess it needs a new build of Stashapp to be able to be tested, as I get an out-of-range error if I attempt to use one of the scrapers with groupByURL:
If it works, this fixes #2229