Skip to content

Consider renaming the ConstraintsException #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pjhartzell opened this issue Jan 27, 2025 · 0 comments
Open

Consider renaming the ConstraintsException #30

pjhartzell opened this issue Jan 27, 2025 · 0 comments
Labels
[package] stapi-fastapi FastAPI server implementation

Comments

@pjhartzell
Copy link
Contributor

Product backend implementations are instructed to raise the the ConstraintsException when an OpportunityRequest or an OrderPayload does not validate. Does this mean that only the CQL2 filter constraints within these objects are to be validated? If so, we should make that clear in both docstrings. If not, from a terminology standpoint, raising a ConstraintsException when an opportunity request or an order payload does not validate is confusing, and renaming the exception to something more generic like InvalidRequestError could improve clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[package] stapi-fastapi FastAPI server implementation
Projects
No open projects
Development

No branches or pull requests

2 participants