Skip to content

Commit a9566c9

Browse files
author
Ståle Pedersen
committed
further caching of Container.instance()
1 parent deab1f3 commit a9566c9

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

impl/src/main/java/org/jboss/weld/context/AbstractContext.java

+4-1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import javax.enterprise.context.spi.CreationalContext;
3232

3333
import org.jboss.weld.Container;
34+
import org.jboss.weld.bootstrap.api.ServiceRegistry;
3435
import org.jboss.weld.context.api.ContextualInstance;
3536
import org.jboss.weld.context.beanstore.BeanStore;
3637
import org.jboss.weld.exceptions.IllegalArgumentException;
@@ -59,6 +60,8 @@ public abstract class AbstractContext implements Context
5960

6061
private final boolean multithreaded;
6162

63+
private static final ServiceRegistry CACHED_SERVICE_REGISTRY = Container.instance().services();
64+
6265
/**
6366
* Constructor
6467
*
@@ -192,7 +195,7 @@ protected static <T> Contextual<T> getContextual(String id)
192195

193196
protected static String getId(Contextual<?> contextual)
194197
{
195-
return Container.instance().services().get(ContextualStore.class).putIfAbsent(contextual);
198+
return CACHED_SERVICE_REGISTRY.get(ContextualStore.class).putIfAbsent(contextual);
196199
}
197200

198201
}

impl/src/main/java/org/jboss/weld/servlet/WeldListener.java

+4-1
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
import org.jboss.weld.context.http.HttpRequestContext;
4040
import org.jboss.weld.context.http.HttpSessionContext;
4141
import org.jboss.weld.exceptions.IllegalStateException;
42+
import org.jboss.weld.manager.BeanManagerImpl;
4243
import org.jboss.weld.servlet.api.helpers.AbstractServletListener;
4344
import org.slf4j.cal10n.LocLogger;
4445

@@ -57,6 +58,8 @@ public class WeldListener extends AbstractServletListener
5758

5859
private static final LocLogger log = loggerFactory().getLogger(SERVLET);
5960

61+
private static final BeanManagerImpl CACHED_BEAN_MANAGER = Container.instance().deploymentManager();
62+
6063
@Override
6164
public void sessionDestroyed(HttpSessionEvent event)
6265
{
@@ -147,7 +150,7 @@ public void requestInitialized(ServletRequestEvent event)
147150

148151
private static Instance<Context> instance()
149152
{
150-
return Container.instance().deploymentManager().instance().select(Context.class);
153+
return CACHED_BEAN_MANAGER.instance().select(Context.class);
151154
}
152155

153156
}

0 commit comments

Comments
 (0)