Skip to content

Commit 32d5ce8

Browse files
committed
chore: fix for POD_NAME and POD_NAMESPACE envs when enableHA is true
1 parent 12b9a19 commit 32d5ce8

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

deployments/kubernetes/chart/reloader/templates/deployment.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ spec:
127127
fieldRef:
128128
fieldPath: {{ $value | quote}}
129129
{{- end }}
130+
{{- end }}
130131
{{- if eq .Values.reloader.watchGlobally false }}
131132
- name: KUBERNETES_NAMESPACE
132133
valueFrom:
@@ -146,7 +147,6 @@ spec:
146147
{{- if .Values.reloader.enableMetricsByNamespace }}
147148
- name: METRICS_COUNT_BY_NAMESPACE
148149
value: enabled
149-
{{- end }}
150150
{{- end }}
151151
ports:
152152
- name: http

deployments/kubernetes/chart/reloader/tests/deployment_test.yaml

+13
Original file line numberDiff line numberDiff line change
@@ -48,3 +48,16 @@ tests:
4848
asserts:
4949
- isEmpty:
5050
path: spec.template.spec.containers[0].securityContext
51+
52+
- it: template still sets POD_NAME and POD_NAMESPACE environment variables when enableHA is true
53+
set:
54+
reloader:
55+
enableHA: true
56+
asserts:
57+
- contains:
58+
path: spec.template.spec.containers[0].env
59+
content:
60+
name: POD_NAME
61+
valueFrom:
62+
fieldRef:
63+
fieldPath: metadata.name

0 commit comments

Comments
 (0)