refactor: Improve form validation logic in useEditForm and useNewForm

Author: vladimirvshivkov

.github/workflows/check.yaml

@@ -1,4 +1,4 @@
-name: CI
+name: check
 on: push
 jobs:
   check:

src/Components/Event/useEditForm.ts

@@ -41,7 +41,9 @@ export function useEditForm(event: Models.IEvent) {
     }
 
     _setTitle(value);
-    !err && setValTitle(undefined);
+    if (!err) {
+      setValTitle(undefined);
+    }
 
     return !err;
   }
@@ -89,7 +91,9 @@ export function useEditForm(event: Models.IEvent) {
     }
 
     _setUpdate(value);
-    !err && setValUpdate(undefined);
+    if (!err) {
+      setValUpdate(undefined);
+    }
 
     return !err;
   }
@@ -128,7 +132,9 @@ export function useEditForm(event: Models.IEvent) {
       err = true;
     }
 
-    !err && setValStart(undefined);
+    if (!err) {
+      setValStart(undefined);
+    }
     _setStart(value);
 
     return !err;
@@ -144,7 +150,9 @@ export function useEditForm(event: Models.IEvent) {
       err = true;
     }
 
-    !err && setValEnd(undefined);
+    if (!err) {
+      setValEnd(undefined);
+    }
     _setEnd(value);
 
     return !err;

src/Components/New/useNewForm.ts

@@ -36,8 +36,9 @@ export function useNewForm() {
     }
 
     _setTitle(value);
-    !err && setValTitle(undefined);
-
+    if (!err) {
+      setValTitle(undefined);
+    }
     return !err;
   }
 
@@ -75,8 +76,9 @@ export function useNewForm() {
     }
 
     _setDescription(value);
-    !err && setValDescription(undefined);
-
+    if (!err) {
+      setValDescription(undefined);
+    }
     return !err;
   }
 
@@ -95,7 +97,9 @@ export function useNewForm() {
       err = true;
     }
 
-    !err && setValStart(undefined);
+    if (!err) {
+      setValStart(undefined);
+    }
     _setStart(value);
 
     return !err;
@@ -111,7 +115,9 @@ export function useNewForm() {
       err = true;
     }
 
-    !err && setValEnd(undefined);
+    if (!err) {
+      setValEnd(undefined);
+    }
     _setEnd(value);
 
     return !err;
@@ -134,8 +140,9 @@ export function useNewForm() {
     }
 
     _setServices(updated);
-    !err && setValServices(undefined);
-
+    if (!err) {
+      setValServices(undefined);
+    }
     return !err;
   }