Skip to content

Commit 5aecf25

Browse files
committed
Removes unused secret environment variables
Eliminates SD_REDIRECT_URL, SD_LOGOUT_REDIRECT_URL, and SD_AUTH_SECRET from workflow files and Dockerfile to streamline the build process. Improves security by reducing the exposure of unnecessary secrets.
1 parent 6658029 commit 5aecf25

File tree

3 files changed

+0
-10
lines changed

3 files changed

+0
-10
lines changed

.github/workflows/docker-build-push-on-tag-or-release.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,4 +56,3 @@ jobs:
5656
SD_AUTHORITY_URL=${{ secrets.SD_AUTHORITY_URL }}
5757
SD_REDIRECT_URL=${{ secrets.SD_REDIRECT_URL }}
5858
SD_LOGOUT_REDIRECT_URL=${{ secrets.SD_LOGOUT_REDIRECT_URL }}
59-
SD_AUTH_SECRET=${{ secrets.SD_AUTH_SECRET }}

.github/workflows/docker-build.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,6 @@ jobs:
5050
SD_BACKEND_URL=${{ secrets.SD_BACKEND_URL }}
5151
SD_CLIENT_ID=${{ secrets.SD_CLIENT_ID }}
5252
SD_AUTHORITY_URL=${{ secrets.SD_AUTHORITY_URL }}
53-
SD_REDIRECT_URL=${{ secrets.SD_REDIRECT_URL }}
54-
SD_LOGOUT_REDIRECT_URL=${{ secrets.SD_LOGOUT_REDIRECT_URL }}
55-
SD_AUTH_SECRET=${{ secrets.SD_AUTH_SECRET }}
5653
5754
push_if_merged:
5855
if: github.event.pull_request.merged == true
@@ -97,6 +94,3 @@ jobs:
9794
SD_BACKEND_URL=${{ secrets.SD_BACKEND_URL }}
9895
SD_CLIENT_ID=${{ secrets.SD_CLIENT_ID }}
9996
SD_AUTHORITY_URL=${{ secrets.SD_AUTHORITY_URL }}
100-
SD_REDIRECT_URL=${{ secrets.SD_REDIRECT_URL }}
101-
SD_LOGOUT_REDIRECT_URL=${{ secrets.SD_LOGOUT_REDIRECT_URL }}
102-
SD_AUTH_SECRET=${{ secrets.SD_AUTH_SECRET }}

Dockerfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
FROM node:lts-alpine AS base
22

3-
43
ENV PNPM_HOME="/pnpm"
54
ENV PATH="$PNPM_HOME:$PATH"
65
RUN corepack enable
@@ -15,8 +14,6 @@ RUN pnpm install --frozen-lockfile
1514
RUN --mount=type=secret,id=SD_BACKEND_URL,env=SD_BACKEND_URL \
1615
--mount=type=secret,id=SD_CLIENT_ID,env=SD_CLIENT_ID \
1716
--mount=type=secret,id=SD_AUTHORITY_URL,env=SD_AUTHORITY_URL \
18-
--mount=type=secret,id=SD_REDIRECT_URL,env=SD_REDIRECT_URL \
19-
--mount=type=secret,id=SD_LOGOUT_REDIRECT_URL,env=SD_LOGOUT_REDIRECT_URL \
2017
pnpm run build
2118

2219
FROM nginx:stable-alpine

0 commit comments

Comments
 (0)