Skip to content

retries #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aslemammad opened this issue Jan 19, 2025 · 7 comments
Open

retries #316

Aslemammad opened this issue Jan 19, 2025 · 7 comments

Comments

@Aslemammad
Copy link
Member

@sapphi-red shared this amazing idea.

Image

@sapphi-red
Copy link

@Aslemammad Do you have plans to implement this? If not, would you give me the logs on the server side for 500 errors so that I can try implementing it?

@Aslemammad
Copy link
Member Author

yes, i'm thinking of doing that in the cli package! what do you think? so any 500 error we get, we'll do a retry.

@AmirSa12 can you tackle this soon?

@sapphi-red
Copy link

I think it's on the server side and not the cli. The error happens when requesting the package.
https://github.com/vitejs/vite-ecosystem-ci/actions/runs/14505881712/job/40695132986#step:8:30

@sapphi-red
Copy link

Ah, I noticed that it can be mitigated on the ecosystem-ci side.
vitejs/vite-ecosystem-ci#383

@Aslemammad
Copy link
Member Author

amazing, so that solves your issue completely? and it does it only for the manifest as far as i know, but i guess that's enough.

@sapphi-red
Copy link

sapphi-red commented Apr 18, 2025

It should work in theory, but I'm not completely sure. I'll get back to you if it doesn't work. Still, having the retry on the server side is probably a good idea (though it's not a high priority).

@Aslemammad
Copy link
Member Author

thank you so much! let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants