Skip to content

Commit 35a4d1c

Browse files
authored
Allow None in rehydration (#263)
1 parent 513de60 commit 35a4d1c

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

src/pypgstac/src/lib.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,16 @@ fn hydrate_any<'a>(base: &PyAny, item: &'a PyAny) -> PyResult<&'a PyAny> {
3838
if let Ok(item) = item.downcast::<PyDict>() {
3939
if let Ok(base) = base.downcast::<PyDict>() {
4040
hydrate_dict(base, item).map(|item| item.into())
41+
} else if base.is_none() {
42+
Ok(item)
4143
} else {
4244
Err(anyhow!("type mismatch").into())
4345
}
4446
} else if let Ok(item) = item.downcast::<PyList>() {
4547
if let Ok(base) = base.downcast::<PyList>() {
4648
hydrate_list(base, item).map(|item| item.into())
49+
} else if base.is_none() {
50+
Ok(item)
4751
} else {
4852
Err(anyhow!("type mismatch").into())
4953
}
@@ -73,7 +77,7 @@ fn hydrate_dict<'a>(base: &PyDict, item: &'a PyDict) -> PyResult<&'a PyDict> {
7377
.map(|s| s == MAGIC_MARKER)
7478
.unwrap_or(false)
7579
{
76-
item.del_item(&key)?;
80+
item.del_item(key)?;
7781
} else {
7882
item.set_item(key, hydrate(base_value, item_value)?)?;
7983
}

src/pypgstac/tests/hydration/test_hydrate.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
"""Test Hydration."""
2+
23
import json
34
from copy import deepcopy
45
from pathlib import Path
@@ -35,7 +36,9 @@
3536

3637
class TestHydrate:
3738
def hydrate(
38-
self, base_item: Dict[str, Any], item: Dict[str, Any],
39+
self,
40+
base_item: Dict[str, Any],
41+
item: Dict[str, Any],
3942
) -> Dict[str, Any]:
4043
hpy = hydration.hydrate_py(deepcopy(base_item), deepcopy(item))
4144
hrs = hydration.hydrate(deepcopy(base_item), deepcopy(item))
@@ -234,3 +237,9 @@ def test_top_level_base_keys_marked(self) -> None:
234237
hydrated = self.hydrate(base_item, dehydrated)
235238

236239
assert hydrated == {"included": "value", "unique": "value"}
240+
241+
def test_base_none(self) -> None:
242+
base_item = {"value": None}
243+
dehydrated = {"value": {"a": "b"}}
244+
hydrated = self.hydrate(base_item, dehydrated)
245+
assert hydrated == {"value": {"a": "b"}}

0 commit comments

Comments
 (0)