Added query param handling and one test; requires more tests

Author: stablekernel-admin

lib/http_controller.dart

@@ -132,6 +132,7 @@ abstract class HttpController {
                 (attr) => attr.reflectee is Route, orElse: () => null);
         if (routeAttrs != null) {
           var params = (decl as MethodMirror).parameters
+          .where((pm) => !pm.isOptional)
           .map((pm) => MirrorSystem.getName(pm.simpleName))
           .toList();
           Route r = new Route.fromRoute(routeAttrs.reflectee, params);
@@ -177,6 +178,7 @@ abstract class HttpController {
     reflect(this).type.declarations[handlerMethodSymbol] as MethodMirror;
 
     return handlerMirror.parameters
+    .where((methodParmeter) => !methodParmeter.isOptional)
     .map((methodParameter) {
       var value = this.resourceRequest.pathParameters[MirrorSystem.getName(methodParameter.simpleName)];
       var parameterType = methodParameter.type;
@@ -185,14 +187,37 @@ abstract class HttpController {
     }).toList();
   }
 
+  Map<String, dynamic> _queryParametersForRequest(ResourceRequest req, Symbol handlerMethodSymbol) {
+    var queryParams = req.request.uri.queryParameters;
+    if(queryParams.length == 0) {
+      return null;
+    }
+
+    var optionalParams = (reflect(this).type.declarations[handlerMethodSymbol] as MethodMirror)
+      .parameters.where((methodParameter) => methodParameter.isOptional).toList();
+
+    var retMap = {};
+    queryParams.forEach((k, v) {
+      var keySymbol = new Symbol(k);
+      var matchingParameter = optionalParams.firstWhere((p) => p.simpleName == keySymbol, orElse: () => null);
+      if(matchingParameter != null) {
+        retMap[keySymbol] = v;
+      }
+    });
+
+    return retMap;
+  }
+
   Future process() async {
     try {
       var methodSymbol = _routeMethodSymbolForRequest(resourceRequest);
       var handlerParameters = _parametersForRequest(resourceRequest, methodSymbol);
+      var handlerQueryParameters = _queryParametersForRequest(resourceRequest, methodSymbol);
+
       requestBody = await _readRequestBodyForRequest(resourceRequest);
 
       Future<Response> eventualResponse =
-      reflect(this).invoke(methodSymbol, handlerParameters).reflectee;
+      reflect(this).invoke(methodSymbol, handlerParameters, handlerQueryParameters).reflectee;
 
       var response = await eventualResponse;
 

lib/resource_request.dart

@@ -12,7 +12,6 @@ class ResourceRequest {
   /// all of the request information provided by the client.
   final HttpRequest request;
 
-
   /// The response object of this [ResourceRequest].
   ///
   /// To respond to a request, this object must be written to. It is the same

test/controller_tests.dart

@@ -89,6 +89,16 @@ void main() {
     expect(res.statusCode, 415);
   });
 
+  test("Query parameters get delivered if exposed as optional params", () async {
+    serve(new QController(), null);
+
+    var res = await http.get("http://localhost:4040/a?opt=x");
+
+    expect(res.body, "\"OK\"");
+
+    res = await http.get("http://localhost:4040/a");
+    expect(res.body, "\"NOT\"");
+  });
 
 
 }
@@ -124,4 +134,14 @@ class TController extends HttpController {
 
     return new Response.ok(body);
   }
+}
+
+class QController extends HttpController {
+  @httpGet
+  Future<Response> getOne({String opt: null}) async {
+    if(opt == null) {
+      return new Response.ok("NOT");
+    }
+    return new Response.ok("OK");
+  }
 }