TypeReflectionProvider ignores abstract IComponents #88

Author: sschmid

Entitas/Entitas/CodeGenerator/Providers/TypeReflectionProvider.cs

@@ -20,6 +20,7 @@ public TypeReflectionProvider(Type[] types, string[] poolNames) {
         public static ComponentInfo[] GetComponentInfos(Type[] types) {
             return types
                 .Where(type => !type.IsInterface)
+                .Where(type => !type.IsAbstract)
                 .Where(type => type.GetInterfaces().Any(i => i.FullName == "Entitas.IComponent"))
                 .Select(type => CreateComponentInfo(type))
                 .ToArray();

Tests/Tests.csproj

@@ -274,6 +274,7 @@
       <Link>Linked Libraries\Unity\VisualDebugging\DebugSystems\Feature.cs</Link>
     </Compile>
     <Compile Include="Tests\Entitas\Fixtures\Systems\GroupObserverSubSystemSpy.cs" />
+    <Compile Include="Tests\Entitas\CodeGenerator\Fixtures\Components\AbstractComponent.cs" />
   </ItemGroup>
   <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
   <ItemGroup>

Tests/Tests/Entitas/CodeGenerator/Fixtures/Components/AbstractComponent.cs

@@ -0,0 +1,5 @@
+using Entitas;
+
+public abstract class AbstractComponent : IComponent {
+}
+

Tests/Tests/Entitas/CodeGenerator/Providers/describe_TypeReflectionProvider.cs

@@ -40,6 +40,11 @@ void when_providing() {
                 provider.componentInfos.should_be_empty();
             };
 
+            it["finds no components and ignores abstract classes"] = () => {
+                var provider = new TypeReflectionProvider(new [] { typeof(AbstractComponent) }, new string[0]);
+                provider.componentInfos.should_be_empty();
+            };
+
             it["creates component info from found component"] = () => {
                 var provider = new TypeReflectionProvider(new [] { typeof(ComponentA) }, new string[0]);
                 provider.componentInfos.Length.should_be(1);