add: следующая итерация датумного ИИ у обезьян + собаки! (#6622)

* до фиксов

* ЗАКОМПИЛЛИЛОСЬ

* ой.

* еще пачка фиксов

* вырезание диспозала

* наконец-то блин

* сделано

* пиздаа

* первая пачка багфиксов

теперь собак можно приковать к кроватям, плюсом они могут из них выбираться.
Фиксы рантаймов у мартых

* фиксы

Author: NightDawnFox

code/__DEFINES/ai.dm

@@ -1,15 +1,20 @@
-#define GET_AI_BEHAVIOR(behavior_type) SSai_controllers.ai_behaviors[behavior_type]
+#define GET_AI_BEHAVIOR(behavior_type) SSai_behaviors.ai_behaviors[behavior_type]
 #define HAS_AI_CONTROLLER_TYPE(thing, type) istype(thing?.ai_controller, type)
 
-#define AI_STATUS_ON		1
-#define AI_STATUS_OFF		2
+#define AI_STATUS_ON 1
+#define AI_STATUS_OFF 2
 
 
 ///Monkey checks
 #define SHOULD_RESIST(source) (source.on_fire || source.buckled || HAS_TRAIT(source, TRAIT_RESTRAINED) || (source.pulledby && source.pulledby.grab_state > GRAB_PASSIVE))
+#define IS_DEAD_OR_INCAP(source) (source.incapacitated() || source.stat)
 
-///Max pathing attempts before auto-fail
-#define MAX_PATHING_ATTEMPTS 30
+///For JPS pathing, the maximum length of a path we'll try to generate. Should be modularized depending on what we're doing later on
+#define AI_MAX_PATH_LENGTH 30 // 30 is possibly overkill since by default we lose interest after 14 tiles of distance, but this gives wiggle room for weaving around obstacles
+
+///Cooldown on planning if planning failed last time
+
+#define AI_FAILED_PLANNING_COOLDOWN 1.5 SECONDS
 
 ///Flags for ai_behavior new()
 #define AI_CONTROLLER_INCOMPATIBLE (1<<0)
@@ -19,16 +24,163 @@
 ///Does this task let you perform the action while you move closer? (Things like moving and shooting)
 #define AI_BEHAVIOR_MOVE_AND_PERFORM (1<<1)
 
+///AI flags
+#define STOP_MOVING_WHEN_PULLED (1<<0)
+
+///Subtree defines
+
+///This subtree should cancel any further planning, (Including from other subtrees)
+#define SUBTREE_RETURN_FINISH_PLANNING 1
+
+//Generic BB keys
+#define BB_CURRENT_MIN_MOVE_DISTANCE "min_move_distance"
 
 ///Monkey AI controller blackboard keys
 
 #define BB_MONKEY_AGRESSIVE "BB_monkey_agressive"
+#define BB_MONKEY_GUN_NEURONS_ACTIVATED "BB_monkey_gun_aware"
+#define BB_MONKEY_GUN_WORKED "BB_monkey_gun_worked"
 #define BB_MONKEY_BEST_FORCE_FOUND "BB_monkey_bestforcefound"
 #define BB_MONKEY_ENEMIES "BB_monkey_enemies"
 #define BB_MONKEY_BLACKLISTITEMS "BB_monkey_blacklistitems"
 #define BB_MONKEY_PICKUPTARGET "BB_monkey_pickuptarget"
 #define BB_MONKEY_PICKPOCKETING "BB_monkey_pickpocketing"
 #define BB_MONKEY_CURRENT_ATTACK_TARGET "BB_monkey_current_attack_target"
+#define BB_MONKEY_CURRENT_PRESS_TARGET "BB_monkey_current_press_target"
+#define BB_MONKEY_CURRENT_GIVE_TARGET "BB_monkey_current_give_target"
 #define BB_MONKEY_TARGET_DISPOSAL "BB_monkey_target_disposal"
 #define BB_MONKEY_DISPOSING "BB_monkey_disposing"
 #define BB_MONKEY_RECRUIT_COOLDOWN "BB_monkey_recruit_cooldown"
+#define BB_MONKEY_NEXT_HUNGRY "BB_monkey_next_hungry"
+
+
+///Haunted item controller defines
+
+///Chance for haunted item to haunt someone
+#define HAUNTED_ITEM_ATTACK_HAUNT_CHANCE 10
+///Chance for haunted item to try to get itself let go.
+#define HAUNTED_ITEM_ESCAPE_GRASP_CHANCE 20
+///Chance for haunted item to warp somewhere new
+#define HAUNTED_ITEM_TELEPORT_CHANCE 4
+///Amount of aggro you get when picking up a haunted item
+#define HAUNTED_ITEM_AGGRO_ADDITION 2
+
+///Blackboard keys for haunted items
+#define BB_TO_HAUNT_LIST "BB_to_haunt_list"
+///Actual mob the item is haunting at the moment
+#define BB_HAUNT_TARGET "BB_haunt_target"
+///Amount of successful hits in a row this item has had
+#define BB_HAUNTED_THROW_ATTEMPT_COUNT "BB_haunted_throw_attempt_count"
+
+///Cursed item controller defines
+
+//defines
+///how far a cursed item will still try to chase a target
+#define CURSED_VIEW_RANGE 7
+#define CURSED_ITEM_TELEPORT_CHANCE 4
+//blackboards
+
+///Actual mob the item is haunting at the moment
+#define BB_CURSE_TARGET "BB_haunt_target"
+///Where the item wants to land on
+#define BB_TARGET_SLOT "BB_target_slot"
+///Amount of successful hits in a row this item has had
+#define BB_CURSED_THROW_ATTEMPT_COUNT "BB_cursed_throw_attempt_count"
+
+///Vending machine AI controller blackboard keys
+#define BB_VENDING_CURRENT_TARGET "BB_vending_current_target"
+#define BB_VENDING_TILT_COOLDOWN "BB_vending_tilt_cooldown"
+#define BB_VENDING_UNTILT_COOLDOWN "BB_vending_untilt_cooldown"
+#define BB_VENDING_BUSY_TILTING "BB_vending_busy_tilting"
+#define BB_VENDING_LAST_HIT_SUCCESSFUL "BB_vending_last_hit_succesful"
+
+///Robot customer AI controller blackboard keys
+#define BB_CUSTOMER_CURRENT_ORDER "BB_customer_current_order"
+#define BB_CUSTOMER_MY_SEAT "BB_customer_my_seat"
+#define BB_CUSTOMER_PATIENCE "BB_customer_patience"
+#define BB_CUSTOMER_CUSTOMERINFO "BB_customer_customerinfo"
+#define BB_CUSTOMER_EATING "BB_customer_eating"
+#define BB_CUSTOMER_ATTENDING_VENUE "BB_customer_attending_avenue"
+#define BB_CUSTOMER_LEAVING "BB_customer_leaving"
+#define BB_CUSTOMER_CURRENT_TARGET "BB_customer_current_target"
+/// Robot customer has said their can't find seat line at least once. Used to rate limit how often they'll complain after the first time.
+#define BB_CUSTOMER_SAID_CANT_FIND_SEAT_LINE "BB_customer_said_cant_find_seat_line"
+
+
+///Hostile AI controller blackboard keys
+#define BB_HOSTILE_ORDER_MODE "BB_HOSTILE_ORDER_MODE"
+#define BB_HOSTILE_FRIEND "BB_HOSTILE_FRIEND"
+#define BB_HOSTILE_ATTACK_WORD "BB_HOSTILE_ATTACK_WORD"
+#define BB_FOLLOW_TARGET "BB_FOLLOW_TARGET"
+#define BB_ATTACK_TARGET "BB_ATTACK_TARGET"
+#define BB_VISION_RANGE "BB_VISION_RANGE"
+
+/// Basically, what is our vision/hearing range.
+#define BB_HOSTILE_VISION_RANGE 10
+/// After either being given a verbal order or a pointing order, ignore further of each for this duration
+#define AI_HOSTILE_COMMAND_COOLDOWN 2 SECONDS
+
+// hostile command modes (what pointing at something/someone does depending on the last order the carp heard)
+/// Don't do anything (will still react to stuff around them though)
+#define HOSTILE_COMMAND_NONE 0
+/// Will attack a target.
+#define HOSTILE_COMMAND_ATTACK 1
+/// Will follow a target.
+#define HOSTILE_COMMAND_FOLLOW 2
+
+///Dog AI controller blackboard keys
+
+#define BB_SIMPLE_CARRY_ITEM "BB_SIMPLE_CARRY_ITEM"
+#define BB_FETCH_TARGET "BB_FETCH_TARGET"
+#define BB_FETCH_IGNORE_LIST "BB_FETCH_IGNORE_LISTlist"
+#define BB_FETCH_DELIVER_TO "BB_FETCH_DELIVER_TO"
+#define BB_DOG_FRIENDS "BB_DOG_FRIENDS"
+#define BB_DOG_ORDER_MODE "BB_DOG_ORDER_MODE"
+#define BB_DOG_PLAYING_DEAD "BB_DOG_PLAYING_DEAD"
+#define BB_DOG_HARASS_TARGET "BB_DOG_HARASS_TARGET"
+
+/// Basically, what is our vision/hearing range for picking up on things to fetch/
+#define AI_DOG_VISION_RANGE	10
+/// What are the odds someone petting us will become our friend?
+#define AI_DOG_PET_FRIEND_PROB 15
+/// After this long without having fetched something, we clear our ignore list
+#define AI_FETCH_IGNORE_DURATION 30 SECONDS
+/// After being ordered to heel, we spend this long chilling out
+#define AI_DOG_HEEL_DURATION 20 SECONDS
+/// After either being given a verbal order or a pointing order, ignore further of each for this duration
+#define AI_DOG_COMMAND_COOLDOWN	2 SECONDS
+
+// dog command modes (what pointing at something/someone does depending on the last order the dog heard)
+/// Don't do anything (will still react to stuff around them though)
+#define DOG_COMMAND_NONE 0
+/// Will try to pick up and bring back whatever you point to
+#define DOG_COMMAND_FETCH 1
+/// Will get within a few tiles of whatever you point at and continually growl/bark. If the target is a living mob who gets too close, the dog will attack them with bites
+#define DOG_COMMAND_ATTACK 2
+
+//enumerators for parsing command speech
+#define COMMAND_HEEL "Heel"
+#define COMMAND_FETCH "Fetch"
+#define COMMAND_FOLLOW "Follow"
+#define COMMAND_STOP "Stop"
+#define COMMAND_ATTACK "Attack"
+#define COMMAND_DIE "Play Dead"
+
+///bane ai
+#define BB_BANE_BATMAN "BB_bane_batman"
+//yep thats it
+
+
+//Hunting defines
+#define SUCCESSFUL_HUNT_COOLDOWN 5 SECONDS
+
+///Hunting BB keys
+#define BB_CURRENT_HUNTING_TARGET "BB_current_hunting_target"
+#define BB_HUNTING_COOLDOWN "BB_HUNTING_COOLDOWN"
+
+///Basic Mob Keys
+
+///Targetting subtrees
+#define BB_BASIC_MOB_CURRENT_TARGET "BB_basic_current_target"
+#define BB_BASIC_MOB_CURRENT_TARGET_HIDING_LOCATION "BB_basic_current_target_hiding_location"
+#define BB_TARGETTING_DATUM "targetting_datum"

code/__DEFINES/dcs/signals.dm

@@ -18,6 +18,8 @@
 #define COMSIG_GLOB_MOB_DEATH "!mob_death"
 /// global living say plug - use sparingly: (mob/speaker , message)
 #define COMSIG_GLOB_LIVING_SAY_SPECIAL "!say_special"
+/// a person somewhere has thrown something : (mob/living/carbon/carbon_thrower, target)
+#define COMSIG_GLOB_CARBON_THROW_THING	"!throw_thing"
 /// called by datum/cinematic/play() : (datum/cinematic/new_cinematic)
 #define COMSIG_GLOB_PLAY_CINEMATIC "!play_cinematic"
 	#define COMPONENT_GLOB_BLOCK_CINEMATIC (1<<0)
@@ -486,6 +488,8 @@
 	#define SPEECH_FORCED 7 */
 ////from mob/living/adjust_fire_stacks()
 #define COMSIG_MOB_ADJUST_FIRE "mob_adjust_fire"
+/// from base of /mob/living/attack_alien(): (user)
+#define COMSIG_MOB_ATTACK_ALIEN "mob_attack_alien"
 
 ////from mob/living/adjust_wet_stacks()
 #define COMSIG_MOB_ADJUST_WET "mob_adjust_wet"

code/__DEFINES/is_helpers.dm

@@ -21,6 +21,9 @@
 
 #define isbrain(A) (istype(A, /mob/living/carbon/brain))
 
+// basic mobs
+#define isbasicmob(A) (istype(A, /mob/living/basic))
+
 // Carbon mobs
 #define iscarbon(A) (istype(A, /mob/living/carbon))
 

code/__DEFINES/monkeys.dm

@@ -25,7 +25,8 @@
 #define MONKEY_ATTACK_DISARM_PROB 			50
 /// probability that monkey will get recruited when friend is attacked
 #define MONKEY_RECRUIT_PROB 				25
-
+/// probability for the monkey to aggro when attacked
+#define MONKEY_RETALIATE_PROB 				85
 /// probability for the monkey to aggro when attacked with harm intent
 #define MONKEY_RETALIATE_HARM_PROB 			95
 /// probability for the monkey to aggro when attacked with disarm intent

code/__DEFINES/subsystems.dm

@@ -125,6 +125,7 @@
 #define FIRE_PRIORITY_AIR			20
 #define FIRE_PRIORITY_NPC			20
 #define FIRE_PRIORITY_NPC_MOVEMENT  21
+#define FIRE_PRIORITY_NPC_ACTIONS	22
 #define FIRE_PRIORITY_PATHFINDING	23
 #define FIRE_PRIORITY_PROCESS		25
 #define FIRE_PRIORITY_THROWING		25

code/__DEFINES/traits/declarations.dm

@@ -299,3 +299,5 @@ Remember to update _globalvars/traits.dm if you're adding/removing/renaming trai
 #define TRAIT_BLOB_ZOMBIFIED "blob_zombified"
 
 #define TRAIT_BEING_OFFERED "offered"
+/// This atom can ignore the "is on a turf" check for simple AI datum attacks, allowing them to attack from bags or lockers as long as any other conditions are met
+#define TRAIT_AI_BAGATTACK "bagattack"

code/__HELPERS/heap.dm

@@ -11,29 +11,35 @@
 	L = new()
 	cmp = compare
 
-/datum/heap/proc/IsEmpty()
-	return !L.len
+/datum/heap/Destroy(force, ...)
+	for(var/i in L) // because this is before the list helpers are loaded
+		qdel(i)
+	L = null
+	return ..()
 
-//Insert and place at its position a new node in the heap
-/datum/heap/proc/Insert(atom/A)
+/datum/heap/proc/is_empty()
+	return !length(L)
+
+/// insert and place at its position a new node in the heap
+/datum/heap/proc/insert(atom/A)
 
 	L.Add(A)
-	Swim(L.len)
+	swim(length(L))
 
 //removes and returns the first element of the heap
 //(i.e the max or the min dependant on the comparison function)
-/datum/heap/proc/Pop()
-	if(!L.len)
+/datum/heap/proc/pop()
+	if(!length(L))
 		return null
 	. = L[1]
 
-	L[1] = L[L.len]
-	L.Cut(L.len)
-
-	Sink(1)
+	L[1] = L[length(L)]
+	L.Cut(length(L))
+	if(length(L))
+		sink(1)
 
 //Get a node up to its right position in the heap
-/datum/heap/proc/Swim(index)
+/datum/heap/proc/swim(index)
 	var/parent = round(index * 0.5)
 
 	while(parent > 0 && (call(cmp)(L[index], L[parent]) > 0))
@@ -42,21 +48,21 @@
 		parent = round(index * 0.5)
 
 //Get a node down to its right position in the heap
-/datum/heap/proc/Sink(index)
-	var/g_child = GetGreaterChild(index)
+/datum/heap/proc/sink(index)
+	var/g_child = get_greater_child(index)
 
 	while(g_child > 0 && (call(cmp)(L[index], L[g_child]) < 0))
 		L.Swap(index, g_child)
 		index = g_child
-		g_child = GetGreaterChild(index)
+		g_child = get_greater_child(index)
 
 //Returns the greater (relative to the comparison proc) of a node children
 //or 0 if there's no child
-/datum/heap/proc/GetGreaterChild(index)
-	if(index * 2 > L.len)
+/datum/heap/proc/get_greater_child(index)
+	if(index * 2 > length(L))
 		return 0
 
-	if(index * 2 + 1 > L.len)
+	if(index * 2 + 1 > length(L))
 		return index * 2
 
 	if(call(cmp)(L[index * 2], L[index * 2 + 1]) < 0)
@@ -65,11 +71,11 @@
 		return index * 2
 
 //Replaces a given node so it verify the heap condition
-/datum/heap/proc/ReSort(atom/A)
+/datum/heap/proc/resort(atom/A)
 	var/index = L.Find(A)
 
-	Swim(index)
-	Sink(index)
+	swim(index)
+	sink(index)
 
 /datum/heap/proc/List()
 	. = L.Copy()

code/__HELPERS/paths/jps.dm

@@ -115,7 +115,7 @@
 		return FALSE
 
 	var/datum/jps_node/current_processed_node = new(start, -1, 0, end)
-	open.Insert(current_processed_node)
+	open.insert(current_processed_node)
 	found_turfs[start] = TRUE // i'm sure this is fine
 	return TRUE
 
@@ -127,8 +127,8 @@
 	if(QDELETED(requester))
 		return FALSE
 
-	while(!open.IsEmpty() && !path)
-		var/datum/jps_node/current_processed_node = open.Pop() //get the lower f_value turf in the open list
+	while(!open.is_empty() && !path)
+		var/datum/jps_node/current_processed_node = open.pop() //get the lower f_value turf in the open list
 		if(max_distance && (current_processed_node.number_tiles > max_distance))//if too many steps, don't process that path
 			continue
 
@@ -239,7 +239,7 @@
 		if(interesting)
 			var/datum/jps_node/newnode = new(current_turf, parent_node, steps_taken)
 			if(parent_node) // if we're a diagonal subscan, we'll handle adding ourselves to the heap in the diag
-				open.Insert(newnode)
+				open.insert(newnode)
 			return newnode
 
 
@@ -309,10 +309,10 @@
 
 		if(interesting || possible_child_node)
 			var/datum/jps_node/newnode = new(current_turf, parent_node, steps_taken)
-			open.Insert(newnode)
+			open.insert(newnode)
 			if(possible_child_node)
 				possible_child_node.update_parent(newnode)
-				open.Insert(possible_child_node)
+				open.insert(possible_child_node)
 				if(possible_child_node.tile == end || (mintargetdist && (get_dist(possible_child_node.tile, end) <= mintargetdist)))
 					unwind_path(possible_child_node)
 			return

code/_onclick/other_mobs.dm

@@ -119,11 +119,12 @@
 
 /mob/living/simple_animal/hostile/OnUnarmedAttack(atom/atom, proximity_flag)
 	GiveTarget(atom)
-	
+
 	if(target)
 		return AttackingTarget()
 
 /atom/proc/attack_animal(mob/user)
+	SEND_SIGNAL(src, COMSIG_ATOM_ATTACK_ANIMAL, user)
 	return
 
 /mob/living/RestrainedClickOn(atom/A)

code/controllers/subsystem/processing/ai_basic_avoidance.dm

@@ -0,0 +1,4 @@
+PROCESSING_SUBSYSTEM_DEF(basic_avoidance)
+	name = "Basic Avoidance"
+	flags = SS_NO_INIT
+	wait = 2 SECONDS