fix: alert deduplication logData JSON conversion bug that caused identical logdata to trigger an alert

Author: kris6673

Modules/CIPPCore/Public/GraphHelper/Write-AlertTrace.ps1

@@ -1,22 +1,22 @@
 function Write-AlertTrace {
     <#
     .FUNCTIONALITY
-    Internal function. Pleases most of write-alertmessage for alerting purposes
+    Internal function. Pleases most of Write-AlertTrace for alerting purposes
     #>
     Param(
         $cmdletName,
         $data,
         $tenantFilter
-    )   
+    )
     $Table = Get-CIPPTable -tablename AlertLastRun
     $PartitionKey = (Get-Date -UFormat '%Y%m%d').ToString()
     #Get current row and compare the $logData object. If it's the same, don't write it.
     $Row = Get-CIPPAzDataTableEntity @table -Filter "RowKey eq '$($tenantFilter)-$($cmdletName)' and PartitionKey eq '$PartitionKey'"
     try {
         $RowData = $Row.LogData
-        $Compare = Compare-Object $RowData ($data | ConvertTo-Json -Compress -Depth 10 | Out-String)
+        $Compare = Compare-Object $RowData (ConvertTo-Json -InputObject $data -Compress -Depth 10 | Out-String)
         if ($Compare) {
-            $LogData = ConvertTo-Json $data -Compress -Depth 10 | Out-String
+            $LogData = ConvertTo-Json -InputObject $data -Compress -Depth 10 | Out-String
             $TableRow = @{
                 'PartitionKey' = $PartitionKey
                 'RowKey'       = "$($tenantFilter)-$($cmdletName)"
@@ -27,7 +27,7 @@ function Write-AlertTrace {
             return $data
         }
     } catch {
-        $LogData = ConvertTo-Json $data -Compress -Depth 10 | Out-String
+        $LogData = ConvertTo-Json -InputObject $data -Compress -Depth 10 | Out-String
         $TableRow = @{
             'PartitionKey' = $PartitionKey
             'RowKey'       = "$($tenantFilter)-$($cmdletName)"
@@ -38,4 +38,4 @@ function Write-AlertTrace {
         return $data
     }
 
-}
+}