Skip to content

Commit 3b66cf0

Browse files
committed
Add DKIM domain exclusions
add comment
1 parent e269eee commit 3b66cf0

File tree

2 files changed

+30
-3
lines changed

2 files changed

+30
-3
lines changed

Modules/CIPPCore/Public/Entrypoints/Activity Triggers/Domain Analyser/Push-DomainAnalyserTenant.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ function Push-DomainAnalyserTenant {
2020
return
2121
} else {
2222
try {
23-
# Remove domains that are not wanted, and used for cloud signature services
23+
# Remove domains that are not wanted, and used for cloud signature services. Same exclusions also found in Invoke-CIPPStandardAddDKIM
2424
$ExclusionDomains = @(
2525
'*.microsoftonline.com'
2626
'*.exclaimer.cloud'

Modules/CIPPCore/Public/Standards/Invoke-CIPPStandardAddDKIM.ps1

Lines changed: 29 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,36 @@ function Invoke-CIPPStandardAddDKIM {
6666
return
6767
}
6868

69+
# Same exclusions also found in Push-DomainAnalyserTenant
70+
$ExclusionDomains = @(
71+
'*.microsoftonline.com'
72+
'*.exclaimer.cloud'
73+
'*.excl.cloud'
74+
'*.codetwo.online'
75+
'*.call2teams.com'
76+
'*.signature365.net'
77+
'*.myteamsconnect.io'
78+
'*.teams.dstny.com'
79+
)
6980

70-
$AllDomains = ($BatchResults | Where-Object { $_.DomainName }).DomainName
71-
$DKIM = $BatchResults | Where-Object { $_.Domain } | Select-Object Domain, Enabled, Status
81+
$AllDomains = ($BatchResults | Where-Object { $_.DomainName }).DomainName | ForEach-Object {
82+
$Domain = $_
83+
foreach ($ExclusionDomain in $ExclusionDomains) {
84+
if ($Domain -like $ExclusionDomain) {
85+
$Domain = $null
86+
}
87+
}
88+
if ($null -ne $Domain) { $Domain }
89+
}
90+
$DKIM = $BatchResults | Where-Object { $_.Domain } | Select-Object Domain, Enabled, Status | ForEach-Object {
91+
$Domain = $_
92+
foreach ($ExclusionDomain in $ExclusionDomains) {
93+
if ($Domain.Domain -like $ExclusionDomain) {
94+
$Domain = $null
95+
}
96+
}
97+
if ($null -ne $Domain) { $Domain }
98+
}
7299

73100
# List of domains for each way to enable DKIM
74101
$NewDomains = $AllDomains | Where-Object { $DKIM.Domain -notcontains $_ }

0 commit comments

Comments
 (0)