Skip to content

Commit 093c146

Browse files
Merge pull request KelvinTegelaar#1420 from Ren-Roros-Digital/OutOfOffice
chore: SetOoO consistent variables
2 parents 173a251 + 9bb4001 commit 093c146

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

Modules/CIPPCore/Public/Entrypoints/HTTP Functions/Email-Exchange/Administration/Invoke-ExecSetOoO.ps1

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -11,33 +11,33 @@ Function Invoke-ExecSetOoO {
1111
param($Request, $TriggerMetadata)
1212
try {
1313
$APIName = $Request.Params.CIPPEndpoint
14-
Write-LogMessage -headers $Request.Headers -API $APINAME -message 'Accessed this API' -Sev 'Debug'
15-
$Username = $request.body.userId
16-
$Tenantfilter = $request.body.tenantfilter
17-
if ($Request.body.input) {
18-
$InternalMessage = $Request.body.input
19-
$ExternalMessage = $Request.body.input
14+
Write-LogMessage -headers $Request.Headers -API $APIName -message 'Accessed this API' -Sev 'Debug'
15+
$Username = $Request.Body.userId
16+
$TenantFilter = $Request.Body.tenantFilter
17+
if ($Request.Body.input) {
18+
$InternalMessage = $Request.Body.input
19+
$ExternalMessage = $Request.Body.input
2020
} else {
21-
$InternalMessage = $Request.body.InternalMessage
22-
$ExternalMessage = $Request.body.ExternalMessage
21+
$InternalMessage = $Request.Body.InternalMessage
22+
$ExternalMessage = $Request.Body.ExternalMessage
2323
}
2424
#if starttime and endtime are a number, they are unix timestamps and need to be converted to datetime, otherwise just use them.
25-
$StartTime = if ($Request.body.StartTime -match '^\d+$') { [DateTimeOffset]::FromUnixTimeSeconds([int]$Request.body.StartTime).DateTime } else { $Request.body.StartTime }
26-
$EndTime = if ($Request.body.EndTime -match '^\d+$') { [DateTimeOffset]::FromUnixTimeSeconds([int]$Request.body.EndTime).DateTime } else { $Request.body.EndTime }
25+
$StartTime = if ($Request.Body.StartTime -match '^\d+$') { [DateTimeOffset]::FromUnixTimeSeconds([int]$Request.Body.StartTime).DateTime } else { $Request.Body.StartTime }
26+
$EndTime = if ($Request.Body.EndTime -match '^\d+$') { [DateTimeOffset]::FromUnixTimeSeconds([int]$Request.Body.EndTime).DateTime } else { $Request.Body.EndTime }
2727

2828
$Results = try {
2929
if ($Request.Body.AutoReplyState.value -ne 'Scheduled') {
30-
Set-CIPPOutOfOffice -userid $Username -tenantFilter $TenantFilter -APIName $APINAME -Headers $Request.Headers -InternalMessage $InternalMessage -ExternalMessage $ExternalMessage -State $Request.Body.AutoReplyState.value
30+
Set-CIPPOutOfOffice -userid $Username -tenantFilter $TenantFilter -APIName $APIName -Headers $Request.Headers -InternalMessage $InternalMessage -ExternalMessage $ExternalMessage -State $Request.Body.AutoReplyState.value
3131
} else {
32-
Set-CIPPOutOfOffice -userid $Username -tenantFilter $TenantFilter -APIName $APINAME -Headers $Request.Headers -InternalMessage $InternalMessage -ExternalMessage $ExternalMessage -StartTime $StartTime -EndTime $EndTime -State $Request.Body.AutoReplyState.value
32+
Set-CIPPOutOfOffice -userid $Username -tenantFilter $TenantFilter -APIName $APIName -Headers $Request.Headers -InternalMessage $InternalMessage -ExternalMessage $ExternalMessage -StartTime $StartTime -EndTime $EndTime -State $Request.Body.AutoReplyState.value
3333
}
3434
} catch {
35-
"Could not add out of office message for $($username). Error: $($_.Exception.Message)"
35+
"Could not add out of office message for $($Username). Error: $($_.Exception.Message)"
3636
}
3737

38-
$body = [pscustomobject]@{'Results' = $($results) }
38+
$Body = [PSCustomObject]@{'Results' = $($Results) }
3939
} catch {
40-
$body = [pscustomobject]@{'Results' = "Could not set Out of Office user: $($_.Exception.message)" }
40+
$Body = [PSCustomObject]@{'Results' = "Could not set Out of Office user: $($_.Exception.Message)" }
4141
}
4242

4343
# Associate values to output bindings by calling 'Push-OutputBinding'.

Modules/CIPPCore/Public/Set-CIPPOutOfoffice.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ function Set-CIPPOutOfOffice {
2121
}
2222
if ($State -ne 'Scheduled') {
2323
$null = New-ExoRequest -tenantid $TenantFilter -cmdlet 'Set-MailboxAutoReplyConfiguration' -cmdParams @{Identity = $userid; AutoReplyState = $State; InternalMessage = $InternalMessage; ExternalMessage = $ExternalMessage } -Anchor $userid
24-
Write-LogMessage -headers $Headers -API $APIName -message "Set Out-of-office for $($userid) to $state" -Sev 'Info' -tenant $TenantFilter
25-
return "Set Out-of-office for $($userid) to $state."
24+
Write-LogMessage -headers $Headers -API $APIName -message "Set Out-of-office for $($userid) to $State" -Sev 'Info' -tenant $TenantFilter
25+
return "Set Out-of-office for $($userid) to $State."
2626
} else {
2727
$null = New-ExoRequest -tenantid $TenantFilter -cmdlet 'Set-MailboxAutoReplyConfiguration' -cmdParams @{Identity = $userid; AutoReplyState = $State; InternalMessage = $InternalMessage; ExternalMessage = $ExternalMessage; StartTime = $StartTime; EndTime = $EndTime } -Anchor $userid
2828
Write-LogMessage -headers $Headers -API $APIName -message "Scheduled Out-of-office for $($userid) between $StartTime and $EndTime" -Sev 'Info' -tenant $TenantFilter

Modules/CIPPCore/Public/Standards/Invoke-CIPPStandardIntuneTemplate.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ function Invoke-CIPPStandardIntuneTemplate {
120120
Set-CIPPIntunePolicy -TemplateType $TemplateFile.body.Type -Description $TemplateFile.description -DisplayName $TemplateFile.displayname -RawJSON $templateFile.rawJSON -AssignTo $TemplateFile.AssignTo -ExcludeGroup $TemplateFile.excludeGroup -tenantFilter $Tenant
121121
} catch {
122122
$ErrorMessage = Get-NormalizedError -Message $_.Exception.Message
123-
Write-LogMessage -API 'Standards' -tenant $tenant -message "Failed to create or update Intune Template $PolicyName, Error: $ErrorMessage" -sev 'Error'
123+
Write-LogMessage -API 'Standards' -tenant $tenant -message "Failed to create or update Intune Template $($TemplateFile.displayname), Error: $ErrorMessage" -sev 'Error'
124124
}
125125
}
126126

0 commit comments

Comments
 (0)