Skip to content

Commit 2b42860

Browse files
authored
Fixed feedback widget not mounting with instant navigation (#8275)
1 parent 74f6007 commit 2b42860

File tree

1 file changed

+23
-19
lines changed

1 file changed

+23
-19
lines changed

docs/setup/setting-up-site-analytics.md

Lines changed: 23 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -273,25 +273,29 @@ generated by users interacting with the feedback widget with the help of some
273273
=== ":octicons-file-code-16: `docs/javascripts/feedback.js`"
274274

275275
``` js
276-
var feedback = document.forms.feedback
277-
feedback.hidden = false // (1)!
278-
279-
feedback.addEventListener("submit", function(ev) {
280-
ev.preventDefault()
281-
282-
var page = document.location.pathname // (2)!
283-
var data = ev.submitter.getAttribute("data-md-value")
284-
285-
console.log(page, data) // (3)!
286-
287-
feedback.firstElementChild.disabled = true // (4)!
288-
289-
var note = feedback.querySelector(
290-
".md-feedback__note [data-md-value='" + data + "']"
291-
)
292-
if (note)
293-
note.hidden = false // (5)!
294-
})
276+
document$.subscribe(function() {
277+
var feedback = document.forms.feedback
278+
if (typeof feedback === "undefined") return
279+
280+
feedback.hidden = false // (1)!
281+
282+
feedback.addEventListener("submit", function(ev) {
283+
ev.preventDefault()
284+
285+
var page = document.location.pathname // (2)!
286+
var data = ev.submitter.getAttribute("data-md-value")
287+
288+
console.log(page, data) // (3)!
289+
290+
feedback.firstElementChild.disabled = true // (4)!
291+
292+
var note = feedback.querySelector(
293+
".md-feedback__note [data-md-value='" + data + "']"
294+
)
295+
if (note)
296+
note.hidden = false // (5)!
297+
})
298+
}
295299
```
296300

297301
1. The feedback widget is hidden by default so that it does not appear when

0 commit comments

Comments
 (0)