Skip to content

Commit 0b64e72

Browse files
author
Sébastien Granjoux
committed
Fix undeclared variables when using strict_undefined
Visit target variable in list and dictionary comprehensions
1 parent 07b618a commit 0b64e72

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

doc/build/unreleased/418.rst

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
.. change::
2+
:tags: bug, parser
3+
:tickets: 418
4+
5+
Fix undefined variable errors when strict_undefined is True and using
6+
nested list comprehension.
7+

mako/pyparser.py

+2
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ def visit_FunctionDef(self, node):
9393
def visit_ListComp(self, node):
9494
if self.in_function:
9595
for comp in node.generators:
96+
self.visit(comp.target)
9697
self.visit(comp.iter)
9798
else:
9899
self.generic_visit(node)
@@ -102,6 +103,7 @@ def visit_ListComp(self, node):
102103
def visit_DictComp(self, node):
103104
if self.in_function:
104105
for comp in node.generators:
106+
self.visit(comp.target)
105107
self.visit(comp.iter)
106108
else:
107109
self.generic_visit(node)

0 commit comments

Comments
 (0)