Skip to content

Commit 9871cb8

Browse files
vahidlazionicklasl
authored andcommitted
fix: remove hardcoded targeting_key
1 parent 40ef288 commit 9871cb8

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

confidence/src/resolve.rs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,35 +3,38 @@ use std::collections::HashMap;
33
use async_trait::async_trait;
44
use mockall::automock;
55
use serde_json::Value;
6-
76
use crate::confidence_value::ConfidenceValue;
87
use crate::models::APIConfig;
9-
use crate::models::APIURL;
108
use crate::models::NetworkResolvedFlags;
11-
use crate::models::ResolvedFlags;
129
use crate::models::ResolveError;
1310
use crate::models::ResolveRequest;
11+
use crate::models::ResolvedFlags;
12+
use crate::models::APIURL;
1413
use crate::models::SDK;
1514
use crate::{get_sdk_version, SDK_ID};
15+
use crate::conversion_trait::ToSerdeValueConverter;
1616

1717
#[derive(Clone, Default)]
1818
pub struct ConfidenceResolver;
1919

2020
impl ConfidenceResolver {
21+
2122
async fn make_request(
2223
&self,
2324
config: &APIConfig,
2425
flags: Vec<String>,
2526
_evaluation_context: &HashMap<String, ConfidenceValue>,
2627
) -> Result<NetworkResolvedFlags, ResolveError> {
27-
let mut context = HashMap::new();
28-
context.insert("targeting_key".to_string(), Value::String("sample".to_string()));
29-
3028
let flags: Vec<String> = flags.into_iter().map(|flag| {
3129
let flag_name: Vec<&str> = flag.split(".").collect();
3230
format!("flags/{}", flag_name.first().unwrap())
3331
}).collect();
3432

33+
let context: HashMap<String, Value> = _evaluation_context
34+
.iter()
35+
.map(|(key, value)| (key.clone(), value.clone().convert()))
36+
.collect();
37+
3538
let sdk = SDK::builder().id(SDK_ID).version(get_sdk_version()).build();
3639

3740
let resolve_request = &ResolveRequest::builder()
@@ -93,4 +96,4 @@ impl NetworkFlagResolver for ConfidenceResolver {
9396
let network_response = self.make_request(config, flags, evaluation_context).await?;
9497
Ok(network_response.into())
9598
}
96-
}
99+
}

demo/src/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ let api_config = APIConfig {
1212
region: Region::Global,
1313
};
1414
let mut context = HashMap::new();
15-
context.insert("targeting_key".to_string(), ConfidenceValue::String("Sample".to_string()));
15+
context.insert("visitor_id".to_string(), ConfidenceValue::String("dennis".to_string()));
1616

1717
let confidence = Confidence::new(api_config).with_context(context);
1818

0 commit comments

Comments
 (0)