Skip to content

Commit 0eae573

Browse files
authored
Remove section_parents (#13560)
Docutils revision r10129 [1] removes the member from the namespace. [1]: https://sourceforge.net/p/docutils/code/10129/
1 parent 75400af commit 0eae573

File tree

3 files changed

+1
-32
lines changed

3 files changed

+1
-32
lines changed

sphinx/directives/other.py

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
from pathlib import Path
66
from typing import TYPE_CHECKING, cast
77

8-
import docutils
98
from docutils import nodes
109
from docutils.parsers.rst import directives
1110
from docutils.parsers.rst.directives.misc import Class
@@ -22,15 +21,14 @@
2221

2322
if TYPE_CHECKING:
2423
from collections.abc import Sequence
25-
from typing import Any, ClassVar, Final
24+
from typing import Any, ClassVar
2625

2726
from docutils.nodes import Element, Node
2827

2928
from sphinx.application import Sphinx
3029
from sphinx.util.typing import ExtensionMetadata, OptionSpec
3130

3231

33-
DU_22_PLUS: Final = docutils.__version_info__ >= (0, 22, 0, 'alpha', 0)
3432
glob_re = re.compile(r'.*[*?\[].*')
3533
logger = logging.getLogger(__name__)
3634

@@ -332,14 +330,6 @@ def run(self) -> list[Node]:
332330
surrounding_section_level = memo.section_level
333331
memo.title_styles = []
334332
memo.section_level = 0
335-
if DU_22_PLUS:
336-
# https://github.com/sphinx-doc/sphinx/issues/13539
337-
# https://sourceforge.net/p/docutils/code/10093/
338-
# https://sourceforge.net/p/docutils/patches/213/
339-
surrounding_section_parents = memo.section_parents
340-
memo.section_parents = []
341-
else:
342-
surrounding_section_parents = []
343333
try:
344334
self.state.nested_parse(
345335
self.content, self.content_offset, node, match_titles=True
@@ -375,8 +365,6 @@ def run(self) -> list[Node]:
375365
return []
376366
finally:
377367
memo.title_styles = surrounding_title_styles
378-
if DU_22_PLUS:
379-
memo.section_parents = surrounding_section_parents
380368
memo.section_level = surrounding_section_level
381369

382370

sphinx/util/parsing.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,15 @@
55
import contextlib
66
from typing import TYPE_CHECKING
77

8-
import docutils
98
from docutils.nodes import Element
109
from docutils.statemachine import StringList, string2lines
1110

1211
if TYPE_CHECKING:
1312
from collections.abc import Iterator
14-
from typing import Final
1513

1614
from docutils.nodes import Node
1715
from docutils.parsers.rst.states import RSTState
1816

19-
DU_22_PLUS: Final = docutils.__version_info__ >= (0, 22, 0, 'alpha', 0)
20-
2117

2218
def nested_parse_to_nodes(
2319
state: RSTState,
@@ -79,23 +75,15 @@ def _fresh_title_style_context(state: RSTState) -> Iterator[None]:
7975
memo = state.memo
8076
surrounding_title_styles: list[str | tuple[str, str]] = memo.title_styles
8177
surrounding_section_level: int = memo.section_level
82-
if DU_22_PLUS:
83-
surrounding_section_parents = memo.section_parents
84-
else:
85-
surrounding_section_parents = []
8678
# clear current title styles
8779
memo.title_styles = []
8880
memo.section_level = 0
89-
if DU_22_PLUS:
90-
memo.section_parents = []
9181
try:
9282
yield
9383
finally:
9484
# reset title styles
9585
memo.title_styles = surrounding_title_styles
9686
memo.section_level = surrounding_section_level
97-
if DU_22_PLUS:
98-
memo.section_parents = surrounding_section_parents
9987

10088

10189
def _text_to_string_list(

tests/test_util/test_util_docutils_sphinx_directive.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
from types import SimpleNamespace
44

5-
import docutils
65
from docutils import nodes
76
from docutils.parsers.rst.languages import en as english # type: ignore[attr-defined]
87
from docutils.parsers.rst.states import (
@@ -45,16 +44,10 @@ def make_directive_and_state(
4544
reporter=document.reporter,
4645
language=english,
4746
title_styles=[],
48-
# section_parents=[], # Docutils 0.22+
4947
section_level=0,
5048
section_bubble_up_kludge=False,
5149
inliner=inliner,
5250
)
53-
if docutils.__version_info__ >= (0, 22, 0, 'alpha', 0):
54-
# https://github.com/sphinx-doc/sphinx/issues/13539
55-
# https://sourceforge.net/p/docutils/code/10093/
56-
# https://sourceforge.net/p/docutils/patches/213/
57-
state.memo.section_parents = []
5851
directive = SphinxDirective(
5952
name='test_directive',
6053
arguments=[],

0 commit comments

Comments
 (0)