New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check for bool flag in `stripFlags` (#2251) #2263

Draft

parametalol wants to merge 1 commit into spf13:main from parametalol:fix/2251-boolean-flag-before-command

parametalol commented Mar 30, 2025

A try to fix #2251.

Removed the call to mergePersistentFlags in favor of just collecting all flags, including the ones from the children;
Refactored stripFlags;
Had to reimplement flag.AddFlagSet to check for shorthands.

Tested with unit tests.


          check for bool flag in stripFlags

f5b3993

CLAassistant commented Mar 30, 2025 •

edited

Loading

All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet