construct a new bytes.Reader per each opened file in tarfs #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #486
Currently, every call to
Open
"copies" theFile
, but since it has pointer fields, it's not really the kind of clean independent copy that's desired here. Notably, everyFile
shares the samebytes.Reader
state.This causes a few bugs:
Close
d has haddata
set tonil
, essentially permanently erasing that file.My proposed solution is to introduce an internal
fsEntry
type, and to construct a newtarfs.File
from that data on each call toOpen
. Continuing to share a*tar.Header
field seems fine, as you shouldn't modify that during normal use.