Use MariaDb dumper

The spatie/laravel-backup package currently uses MySQL dumper for all MySQL-compatible databases, including MariaDB.

However, MariaDB has deprecated the mysqldump utility in favor of mariadb-dump as documented in their official documentation.

Recently, a dedicated MariaDB dumper was added to the spatie/db-dumper package in PR #220, which properly uses the mariadb-dump utility.

This PR updates this package to utilize the new dumper when a MariaDB connection is required.

on-behalf-of: @e-solutions-GmbH [email protected]

Author: NiroDeveloper

composer.json

@@ -27,7 +27,7 @@
         "illuminate/notifications": "^10.10.0|^11.0|^12.0",
         "illuminate/support": "^10.10.0|^11.0|^12.0",
         "league/flysystem": "^3.0",
-        "spatie/db-dumper": "^3.7",
+        "spatie/db-dumper": "^3.8",
         "spatie/laravel-package-tools": "^1.6.2",
         "spatie/laravel-signal-aware-command": "^1.2|^2.0",
         "spatie/temporary-directory": "^2.0",

src/Tasks/Backup/DbDumperFactory.php

@@ -7,6 +7,7 @@
 use Illuminate\Support\Arr;
 use Illuminate\Support\Str;
 use Spatie\Backup\Exceptions\CannotCreateDbDumper;
+use Spatie\DbDumper\Databases\MariaDb;
 use Spatie\DbDumper\Databases\MongoDb;
 use Spatie\DbDumper\Databases\MySql;
 use Spatie\DbDumper\Databases\PostgreSql;
@@ -85,7 +86,8 @@ protected static function forDriver(string $dbDriver): DbDumper
         }
 
         return match ($driver) {
-            'mysql', 'mariadb' => new MySql,
+            'mysql' => new MySql,
+            'mariadb' => new MariaDb,
             'pgsql' => new PostgreSql,
             'sqlite' => new Sqlite,
             'mongodb' => new MongoDb,

tests/DbDumperFactoryTest.php

@@ -2,6 +2,7 @@
 
 use Spatie\Backup\Exceptions\CannotCreateDbDumper;
 use Spatie\Backup\Tasks\Backup\DbDumperFactory;
+use Spatie\DbDumper\Databases\MariaDb;
 use Spatie\DbDumper\Databases\MongoDb;
 use Spatie\DbDumper\Databases\MySql;
 use Spatie\DbDumper\Databases\PostgreSql;
@@ -10,6 +11,15 @@
 beforeEach(function () {
     config()->set('database.default', 'mysql');
 
+    config()->set('database.connections.mariadb', [
+        'driver' => 'mariadb',
+        'host' => 'localhost',
+        'port' => 3306,
+        'database' => 'myDb',
+        'username' => 'root',
+        'password' => 'myPassword',
+    ]);
+
     config()->set('database.connections.mongodb', [
         'driver' => 'mongodb',
         'host' => 'localhost',
@@ -40,8 +50,9 @@
     ]);
 });
 
-it('can create instances of mysql and pgsql and mongodb', function () {
+it('can create instances of mysql and mariadb and pgsql and mongodb', function () {
     expect(DbDumperFactory::createFromConnection('mysql'))->toBeInstanceOf(MySql::class);
+    expect(DbDumperFactory::createFromConnection('mariadb'))->toBeInstanceOf(MariaDb::class);
     expect(DbDumperFactory::createFromConnection('pgsql'))->toBeInstanceOf(PostgreSql::class);
     expect(DbDumperFactory::createFromConnection('mongodb'))->toBeInstanceOf(MongoDb::class);
 });