Check whether memory allocation was successful

Author: Garfield96

ext/nokogiri/nokogiri.h

@@ -200,6 +200,8 @@ NOKOPUBFUN VALUE Nokogiri_wrap_xml_document(VALUE klass,
 #define DISCARD_CONST_QUAL(t, v) ((t)(uintptr_t)(v))
 #define DISCARD_CONST_QUAL_XMLCHAR(v) DISCARD_CONST_QUAL(xmlChar *, v)
 
+#define CHECK_ALLOC(p) if (p == NULL) rb_raise(rb_eNoMemError, "Cannot allocate memory")
+
 void Nokogiri_structured_error_func_save(libxmlStructuredErrorHandlerState *handler_state);
 void Nokogiri_structured_error_func_save_and_set(libxmlStructuredErrorHandlerState *handler_state, void *user_data,
     xmlStructuredErrorFunc handler);
@@ -215,6 +217,7 @@ nokogiriSAXTuplePtr
 nokogiri_sax_tuple_new(xmlParserCtxtPtr ctxt, VALUE self)
 {
   nokogiriSAXTuplePtr tuple = malloc(sizeof(nokogiriSAXTuple));
+  CHECK_ALLOC(tuple);
   tuple->self = self;
   tuple->ctxt = ctxt;
   return tuple;

ext/nokogiri/xml_document.c

@@ -570,6 +570,10 @@ rb_xml_document_canonicalize(int argc, VALUE *argv, VALUE self)
   } else {
     long ns_len = RARRAY_LEN(rb_namespaces);
     c_namespaces = calloc((size_t)ns_len + 1, sizeof(xmlChar *));
+    if (c_namespaces == NULL) {
+      xmlOutputBufferClose(c_obuf);
+      rb_raise(rb_eNoMemError, "Cannot allocate memory");
+    }
     for (int j = 0 ; j < ns_len ; j++) {
       VALUE entry = rb_ary_entry(rb_namespaces, j);
       c_namespaces[j] = (xmlChar *)StringValueCStr(entry);
@@ -601,6 +605,7 @@ noko_xml_document_wrap_with_init_args(VALUE klass, xmlDocPtr c_document, int arg
   rb_document = Data_Wrap_Struct(klass, mark, dealloc, c_document);
 
   tuple = (nokogiriTuplePtr)malloc(sizeof(nokogiriTuple));
+  CHECK_ALLOC(tuple);
   tuple->doc = rb_document;
   tuple->unlinkedNodes = st_init_numtable_with_size(128);
   tuple->node_cache = rb_ary_new();

ext/nokogiri/xml_sax_parser.c

@@ -269,6 +269,7 @@ static VALUE
 allocate(VALUE klass)
 {
   xmlSAXHandlerPtr handler = calloc((size_t)1, sizeof(xmlSAXHandler));
+  CHECK_ALLOC(handler);
 
   handler->startDocument = start_document;
   handler->endDocument = end_document;

ext/nokogiri/xml_xpath_context.c

@@ -196,6 +196,7 @@ Nokogiri_marshal_xpath_funcall_and_return_values(xmlXPathParserContextPtr ctx, i
   assert(DOC_RUBY_OBJECT_TEST(ctx->context->doc));
 
   argv = (VALUE *)calloc((size_t)nargs, sizeof(VALUE));
+  CHECK_ALLOC(argv);
   for (int j = 0 ; j < nargs ; ++j) {
     rb_gc_register_address(&argv[j]);
   }

ext/nokogiri/xslt_stylesheet.c

@@ -249,6 +249,7 @@ transform(int argc, VALUE *argv, VALUE self)
 
   param_len = RARRAY_LEN(paramobj);
   params = calloc((size_t)param_len + 1, sizeof(char *));
+  CHECK_ALLOC(params);
   for (j = 0 ; j < param_len ; j++) {
     VALUE entry = rb_ary_entry(paramobj, j);
     const char *ptr = StringValueCStr(entry);