Fix CI checks (#3)

* Fix TS issues

* fix knip

* fix tests

Author: Andarist

knip.json

@@ -3,7 +3,7 @@
   "ignoreWorkspaces": ["test-gatsby", "packages/gatsby-source-workspace"],
   "workspaces": {
     ".": {
-      "ignoreBinaries": ["gatsby", "manypkg"]
+      "ignoreBinaries": ["gatsby", "packages/cli/bin.js"]
     }
   },
   "ignore": ["__fixtures__/**"]

packages/cli/src/checks/__tests__/EXTERNAL_MISMATCH.ts

@@ -1,5 +1,5 @@
-import internalMismatch from "../EXTERNAL_MISMATCH";
-import { getWS, getFakeWS, getRootWS } from "../../test-helpers";
+import internalMismatch from "../EXTERNAL_MISMATCH.ts";
+import { getWS, getFakeWS, getRootWS } from "../../test-helpers.ts";
 
 let rootWorkspace = getRootWS();
 

packages/cli/src/checks/__tests__/INCORRECT_REPOSITORY_FIELD.ts

@@ -1,6 +1,10 @@
-import path from "path";
-import check from "../INCORRECT_REPOSITORY_FIELD";
-import { getWS, getFakeWS, getFakeString, getRootWS } from "../../test-helpers";
+import {
+  getFakeString,
+  getFakeWS,
+  getRootWS,
+  getWS,
+} from "../../test-helpers.ts";
+import check from "../INCORRECT_REPOSITORY_FIELD.ts";
 
 describe("incorrect repository field", () => {
   describe("github", () => {

packages/cli/src/checks/__tests__/INTERNAL_MISMATCH.ts

@@ -1,5 +1,5 @@
-import makeCheck, { ErrorType } from "../INTERNAL_MISMATCH";
-import { getWS, getFakeWS, getRootWS } from "../../test-helpers";
+import { getFakeWS, getRootWS, getWS } from "../../test-helpers.ts";
+import makeCheck, { ErrorType } from "../INTERNAL_MISMATCH.ts";
 
 let rootWorkspace = getRootWS();
 

packages/cli/src/checks/__tests__/INVALID_DEV_AND_PEER_DEPENDENCY.ts

@@ -1,5 +1,5 @@
-import makeCheck from "../INVALID_DEV_AND_PEER_DEPENDENCY_RELATIONSHIP";
-import { getWS, getFakeWS, getRootWS } from "../../test-helpers";
+import { getFakeWS, getRootWS, getWS } from "../../test-helpers.ts";
+import makeCheck from "../INVALID_DEV_AND_PEER_DEPENDENCY_RELATIONSHIP.ts";
 
 let rootWorkspace = getRootWS();
 

packages/cli/src/checks/__tests__/WORKSPACE_REQUIRED.ts

@@ -1,5 +1,5 @@
-import { getWS, getFakeWS, getRootWS } from "../../test-helpers";
-import makeCheck from "../WORKSPACE_REQUIRED";
+import { getFakeWS, getRootWS, getWS } from "../../test-helpers.ts";
+import makeCheck from "../WORKSPACE_REQUIRED.ts";
 let rootWorkspace = getRootWS();
 
 test("should not error if not using workspaceProtocol: require", () => {

packages/cli/src/index.ts

@@ -1,4 +1,4 @@
-import path from "path";
+import path from "node:path";
 import * as logger from "./logger.ts";
 import {
   getPackages,

packages/cli/src/logger.ts

@@ -1,5 +1,5 @@
 import pc from "picocolors";
-import util from "util";
+import util from "node:util";
 
 function format(
   args: Array<any>,

packages/cli/src/run.test.ts

@@ -1,10 +1,15 @@
-import { runCmd } from "./run";
 import fixturez from "fixturez";
-import { exec } from "tinyexec";
 import stripAnsi from "strip-ansi";
+import { exec } from "tinyexec";
 
 const f = fixturez(__dirname);
 
+function stripNodeWarnings(str: string) {
+  return str
+    .replace(/^\(node:\d+\) ExperimentalWarning:.+(\r?\n)?/gm, "")
+    .replace(/^\(Use \`node --trace-warnings \.\.\.\`.+(\r?\n)?/gm, "");
+}
+
 describe("Run command", () => {
   it.each([
     ["package-one", "start", 0],
@@ -19,21 +24,27 @@ describe("Run command", () => {
     ["pkg-two", "start", 1],
     ["@manypkg/basic-fixture-pkg-two", "start", 0],
     ["pkg-two-one", "start", 0],
-    // @ts-ignore
   ])(
     'should execute "%s %s" and exit with %i',
     async (arg0, arg1, expectedExitCode) => {
       const { exitCode, stdout, stderr } = await exec(
-        require.resolve("../bin"),
-        // @ts-ignore
-        ["run", arg0, arg1],
+        "node",
+        [require.resolve("../bin.js"), "run", arg0, arg1],
         {
-          nodeOptions: { cwd: f.find("basic-with-scripts") },
+          nodeOptions: {
+            cwd: f.find("basic-with-scripts"),
+            env: {
+              ...process.env,
+              NODE_OPTIONS: "--experimental-strip-types",
+            },
+          },
         }
       );
       expect(exitCode).toBe(expectedExitCode);
       expect(stripAnsi(stdout.toString())).toMatchSnapshot("stdout");
-      expect(stripAnsi(stderr.toString())).toMatchSnapshot("stderr");
+      expect(stripAnsi(stripNodeWarnings(stderr.toString()))).toMatchSnapshot(
+        "stderr"
+      );
     }
   );
 });

packages/cli/src/test-helpers.ts

@@ -5,7 +5,7 @@
 // Who can say? ¯\_(ツ)_/¯
 
 import { Package } from "@manypkg/get-packages";
-import crypto from "crypto";
+import crypto from "node:crypto";
 
 export let getRootWS = (): Package => {
   return {