No logical code changes; Name changes only, per review comments

Author: renukamanavalan

generic_config_updater/change_applier.py

@@ -24,11 +24,11 @@ def set_verbose(verbose=False):
         logger.set_min_log_priority_notice()
 
 
-def _log_debug(m):
+def log_debug(m):
     logger.log(logger.LOG_PRIORITY_DEBUG, m, print_to_console)
 
 
-def _log_error(m):
+def log_error(m):
     logger.log(logger.LOG_PRIORITY_ERROR, m, print_to_console)
 
 
@@ -98,9 +98,9 @@ def _services_validate(self, old_cfg, upd_cfg, keys):
         for cmd in lst_cmds:
             ret = self._invoke_cmd(cmd, old_cfg, upd_cfg, keys)
             if ret:
-                _log_error("service invoked: {} failed with ret={}".format(cmd, ret))
+                log_error("service invoked: {} failed with ret={}".format(cmd, ret))
                 return ret
-            _log_debug("service invoked: {}".format(cmd))
+            log_debug("service invoked: {}".format(cmd))
         return 0
 
 
@@ -112,11 +112,11 @@ def _upd_data(self, tbl, run_tbl, upd_tbl, upd_keys):
             if run_data != upd_data:
                 set_config(self.config_db, tbl, key, upd_data)
                 upd_keys[tbl][key] = {}
-                _log_debug("Patch affected tbl={} key={}".format(tbl, key))
+                log_debug("Patch affected tbl={} key={}".format(tbl, key))
 
 
     def _report_mismatch(self, run_data, upd_data):
-        _log_error("run_data vs expected_data: {}".format(
+        log_error("run_data vs expected_data: {}".format(
             str(jsondiff.diff(run_data, upd_data))[0:40]))
 
 
@@ -136,7 +136,7 @@ def apply(self, change):
                 self._report_mismatch(run_data, upd_data)
                 ret = -1
         if ret:
-            _log_error("Failed to apply Json change")
+            log_error("Failed to apply Json change")
         return ret
 
 

generic_config_updater/generic_config_updater.conf.json

@@ -52,7 +52,7 @@
             "validate_commands": [ ]
         },
         "rsyslog": {
-            "validate_commands": [ "generic_config_updater.services_validator.ryslog_validator" ]
+            "validate_commands": [ "generic_config_updater.services_validator.rsyslog_validator" ]
         },
         "dhcp-relay": {
             "validate_commands": [ "generic_config_updater.services_validator.dhcp_validator" ]

generic_config_updater/services_validator.py

@@ -22,7 +22,7 @@ def _service_restart(svc_name):
     return rc == 0
 
 
-def ryslog_validator(old_config, upd_config, keys):
+def rsyslog_validator(old_config, upd_config, keys):
     return _service_restart("rsyslog-config")