Skip to content

Commit 7643ac3

Browse files
dgsudharsanmssonicbld
authored andcommitted
[DPB]Fixing return code of breakout command on failure (#3357)
1 parent 313a68c commit 7643ac3

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

config/main.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ def breakout_Ports(cm, delPorts=list(), portJson=dict(), force=False, \
248248
click.echo("*** Printing dependencies ***")
249249
for dep in deps:
250250
click.echo(dep)
251-
sys.exit(0)
251+
sys.exit(1)
252252
else:
253253
click.echo("[ERROR] Port breakout Failed!!! Opting Out")
254254
raise click.Abort()

tests/config_dpb_test.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ def test_config_breakout_verbose(self, sonic_db):
396396
commands["breakout"], ['{}'.format(interface), '{}'.format(newMode), '-v', '-y'], obj=obj)
397397

398398
print(result.exit_code, result.output)
399-
assert result.exit_code == 0
399+
assert result.exit_code == 1
400400
assert 'Dependencies Exist.' in result.output
401401

402402
# verbose must be set while creating instance of ConfigMgmt class
@@ -538,7 +538,7 @@ def config_dpb_port8_2x50G_1x100G():
538538
commands["breakout"], ['{}'.format(interface), '{}'.format(newMode), '-v','-y'], obj=obj)
539539

540540
print(result.exit_code, result.output)
541-
assert result.exit_code == 0
541+
assert result.exit_code == 1
542542
assert 'Dependencies Exist.' in result.output
543543
assert 'Printing dependencies' in result.output
544544
assert 'NO-NSW-PACL-V4' in result.output

0 commit comments

Comments
 (0)