Skip to content

Commit 2381630

Browse files
committed
Flake8 test recommendations fixed
1 parent caa6373 commit 2381630

File tree

1 file changed

+16
-14
lines changed

1 file changed

+16
-14
lines changed

tests/ssdutil_test.py

+16-14
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,15 @@
11
import sys
22
import os
3-
from sonic_platform_base import device_base
43
from unittest.mock import patch, MagicMock
4+
sys.modules['sonic_platform'] = MagicMock()
5+
sys.modules['argparse'] = MagicMock()
56

6-
import pytest
7-
from click.testing import CliRunner
8-
from sonic_py_common import device_info
7+
import ssdutil.main as ssdutil # noqa: E402
98

109
test_path = os.path.dirname(os.path.abspath(__file__))
1110
modules_path = os.path.dirname(test_path)
1211
sys.path.insert(0, modules_path)
1312

14-
sys.modules['sonic_platform'] = MagicMock()
15-
sys.modules['argparse'] = MagicMock()
16-
17-
import ssdutil.main as ssdutil
18-
from .utils import get_result_and_return_code
19-
2013
ssdutil_output = """
2114
Device Model : InnoDisk Corp. - mSATA 3IE3
2215
Health : 99%
@@ -31,26 +24,35 @@
3124
Temperature : 30C
3225
"""
3326

27+
3428
class Ssd():
29+
3530
def get_model(self):
3631
return 'SkyNet'
32+
3733
def get_firmware(self):
3834
return 'ABC'
35+
3936
def get_serial(self):
4037
return 'T1000'
38+
4139
def get_health(self):
4240
return 5
41+
4342
def get_temperature(self):
4443
return 3000
44+
4545
def get_vendor_output(self):
4646
return 'SONiC Test'
4747

48+
4849
class TestSsdutil:
4950

50-
@patch('sonic_py_common.device_info.get_paths_to_platform_and_hwsku_dirs', MagicMock(return_value = ("test_path", "")))
51+
@patch('sonic_py_common.device_info.get_paths_to_platform_and_hwsku_dirs',
52+
MagicMock(return_value=("test_path", "")))
5153
@patch('os.geteuid', MagicMock(return_value=0))
52-
@patch('sonic_platform_base.sonic_storage.ssd.SsdUtil', MagicMock(return_value=Ssd()))
54+
@patch('sonic_platform_base.sonic_storage.ssd.SsdUtil',
55+
MagicMock(return_value=Ssd()))
5356
def test_happy_path(self):
54-
ssdutil.ssdutil()
55-
5657

58+
ssdutil.ssdutil()

0 commit comments

Comments
 (0)