Skip to content

Commit 02394f3

Browse files
Using updated py common utility subintf apis and updating mock_tables
1 parent 62caf8c commit 02394f3

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

config/main.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
from portconfig import get_child_ports
2121
from socket import AF_INET, AF_INET6
2222
from sonic_py_common import device_info, multi_asic
23-
from sonic_py_common.interface import get_interface_table_name, get_port_table_name, intf_get_longname
23+
from sonic_py_common.interface import get_interface_table_name, get_port_table_name, get_intf_longname
2424
from utilities_common import util_base
2525
from swsscommon.swsscommon import SonicV2Connector, ConfigDBConnector
2626
from utilities_common.db import Db
@@ -5901,7 +5901,7 @@ def add_subinterface(ctx, subinterface_name, vid):
59015901
if interface_alias is not None:
59025902
if not port_dict:
59035903
ctx.fail("{} parent interface not found. {} table none".format(interface_alias, intf_table_name))
5904-
if intf_get_longname(interface_alias) not in port_dict.keys():
5904+
if get_intf_longname(interface_alias) not in port_dict.keys():
59055905
ctx.fail("{} parent interface not found".format(subinterface_name))
59065906

59075907
# Validate if parent is portchannel member
@@ -5924,7 +5924,7 @@ def add_subinterface(ctx, subinterface_name, vid):
59245924
if vid is not None:
59255925
subintf_dict.update({"vlan" : vid})
59265926

5927-
if subintf_vlan_check(config_db, intf_get_longname(interface_alias), vid) is True:
5927+
if subintf_vlan_check(config_db, get_intf_longname(interface_alias), vid) is True:
59285928
ctx.fail("Vlan {} encap already configured on other subinterface on {}".format(vid, interface_alias))
59295929

59305930
subintf_dict.update({"admin_status" : "up"})

scripts/intfutil

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ from tabulate import tabulate
1010
from utilities_common import constants
1111
from utilities_common import multi_asic as multi_asic_util
1212
from utilities_common.intf_filter import parse_interface_in_filter
13-
from sonic_py_common.interface import intf_get_longname
13+
from sonic_py_common.interface import get_intf_longname
1414

1515
# mock the redis for unit test purposes #
1616
try:
@@ -314,7 +314,7 @@ def appl_db_portchannel_status_get(appl_db, config_db, po_name, status_type, por
314314
def appl_db_sub_intf_status_get(appl_db, config_db, front_panel_ports_list, portchannel_speed_dict, sub_intf_name, status_type):
315315
sub_intf_sep_idx = sub_intf_name.find(VLAN_SUB_INTERFACE_SEPARATOR)
316316
if sub_intf_sep_idx != -1:
317-
parent_port_name = intf_get_longname(sub_intf_name[:sub_intf_sep_idx])
317+
parent_port_name = get_intf_longname(sub_intf_name[:sub_intf_sep_idx])
318318

319319
full_intf_table_name = "INTF_TABLE" + ":" + sub_intf_name
320320

tests/mock_tables/appl_db.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,8 @@
136136
"speed": "100000"
137137
},
138138
"INTF_TABLE:Ethernet0.10": {
139-
"admin_status": "up"
139+
"admin_status": "up",
140+
"vlan": "10"
140141
},
141142
"INTF_TABLE:Eth64.10": {
142143
"admin_status": "up",

0 commit comments

Comments
 (0)