Skip to content

Many tests are hard-coded to assume 32 ports #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daall opened this issue Aug 6, 2020 · 0 comments
Open

Many tests are hard-coded to assume 32 ports #1384

daall opened this issue Aug 6, 2020 · 0 comments

Comments

@daall
Copy link
Contributor

daall commented Aug 6, 2020

Many of the tests (including the DVS setup in conftest) are hard-coded to assume that there will always be 32 active front panel ports in the system.

However, there was a recent change in sonic-net/sonic-buildimage#4499 that made it possible to create persistent DVS instances with <32 ports. Also, we may want to simulate different SKUs in the future that have much greater port densities, especially with multi-ASIC and chassis support coming down the pipeline.

We should update the tests to accommodate a variable number of ports.

See also: #1373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant