Skip to content

Commit 9e13325

Browse files
sanmalho-gitwangxin
authored andcommitted
Bug fix to get iface_namingmode tests to work on multi-asic linecards of a T2 chassis (#6528)
What is the motivation for this PR? Currently, the following test isfailing on multi-asic linecards on a T2 VoQ chassis. show pfc counters: This fails as the Inband and Recycle ports show in the 'show pfc counters' table while they are not expected. How did you do it? show pfc counters: Treat Inband and Recycle ports on a VoQ chassis as internal ports. Since the inband and recycle ports do not show up in 'show' commands unless we specify '-d all' option, they should be treated similar to internal ports. How did you verify/test it? Ran the test against a multi-asic linecard in a T2 VoQ chassis.
1 parent 7d8f8f0 commit 9e13325

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ansible/library/port_alias.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ def get_portmap(self, asic_id=None, include_internal=False,
162162
else:
163163
alias = name
164164
add_port = False
165-
if role in {"Ext", "Inb", "Rec"} or (role == "Int" and include_internal):
165+
if role in {"Ext"} or (role in ["Int", "Inb", "Rec"] and include_internal):
166166
add_port = True
167167
aliases.append((alias, -1 if port_index == -1 or len(mapping) <= port_index else mapping[port_index]))
168168
portmap[name] = alias

0 commit comments

Comments
 (0)