Skip to content

Commit 1ee79c0

Browse files
authored
Revert "[dhcp_relay] DHCPv6 automatic test (#3565)" (#3755)
This reverts commit cf45c59.
1 parent 74e37bb commit 1ee79c0

File tree

5 files changed

+3
-537
lines changed

5 files changed

+3
-537
lines changed

ansible/group_vars/lab/lab.yml

-3
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,6 @@ snmp_servers: ['10.0.0.9']
3939
# dhcp relay servers
4040
dhcp_servers: ['192.0.0.1', '192.0.0.2', '192.0.0.3', '192.0.0.4']
4141

42-
# dhcpv6 relay servers
43-
dhcpv6_servers: ['fc02:2000::1', 'fc02:2000::2', 'fc02:2000::3', 'fc02:2000::4']
44-
4542
# snmp variables
4643
snmp_rocommunity: public
4744
snmp_location: testlab

ansible/library/minigraph_facts.py

+3-12
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,6 @@ def parse_dpg(dpg, hname):
363363

364364
vlanintfs = child.find(str(QName(ns, "VlanInterfaces")))
365365
dhcp_servers = []
366-
dhcpv6_servers = []
367366
vlans = {}
368367
for vintf in vlanintfs.findall(str(QName(ns, "VlanInterface"))):
369368
vintfname = vintf.find(str(QName(ns, "Name"))).text
@@ -376,12 +375,6 @@ def parse_dpg(dpg, hname):
376375
else:
377376
vlandhcpservers = ""
378377
dhcp_servers = vlandhcpservers.split(";")
379-
vintf_node = vintf.find(str(QName(ns, "Dhcpv6Relays")))
380-
if vintf_node is not None and vintf_node.text is not None:
381-
vlandhcpservers = vintf_node.text
382-
else:
383-
vlandhcpservers = ""
384-
dhcpv6_servers = vlandhcpservers.split(";")
385378
for i, member in enumerate(vmbr_list):
386379
# Skip PortChannel inside Vlan
387380
if member in pcs:
@@ -409,7 +402,7 @@ def parse_dpg(dpg, hname):
409402
if acl_intfs:
410403
acls[aclname] = acl_intfs
411404

412-
return intfs, lo_intfs, mgmt_intf, vlans, pcs, acls, dhcp_servers, dhcpv6_servers
405+
return intfs, lo_intfs, mgmt_intf, vlans, pcs, acls, dhcp_servers
413406
return None, None, None, None, None, None, None
414407

415408
def parse_cpg(cpg, hname):
@@ -585,7 +578,6 @@ def parse_xml(filename, hostname, asic_name=None):
585578
hostname = None
586579
syslog_servers = []
587580
dhcp_servers = []
588-
dhcpv6_servers = []
589581
ntp_servers = []
590582
mgmt_routes = []
591583
bgp_peers_with_range = []
@@ -616,7 +608,7 @@ def parse_xml(filename, hostname, asic_name=None):
616608
for child in root:
617609
if asic_name is None:
618610
if child.tag == str(QName(ns, "DpgDec")):
619-
(intfs, lo_intfs, mgmt_intf, vlans, pcs, acls, dhcp_servers, dhcpv6_servers) = parse_dpg(child, hostname)
611+
(intfs, lo_intfs, mgmt_intf, vlans, pcs, acls, dhcp_servers) = parse_dpg(child, hostname)
620612
elif child.tag == str(QName(ns, "CpgDec")):
621613
(bgp_sessions, bgp_asn, bgp_peers_with_range) = parse_cpg(child, hostname)
622614
elif child.tag == str(QName(ns, "PngDec")):
@@ -627,7 +619,7 @@ def parse_xml(filename, hostname, asic_name=None):
627619
(syslog_servers, ntp_servers, mgmt_routes, deployment_id) = parse_meta(child, hostname)
628620
else:
629621
if child.tag == str(QName(ns, "DpgDec")):
630-
(intfs, lo_intfs, mgmt_intf, vlans, pcs, acls, dhcp_servers, dhcpv6_servers) = parse_dpg(child, asic_name)
622+
(intfs, lo_intfs, mgmt_intf, vlans, pcs, acls, dhcp_servers) = parse_dpg(child, asic_name)
631623
host_lo_intfs = parse_host_loopback(child, hostname)
632624
elif child.tag == str(QName(ns, "CpgDec")):
633625
(bgp_sessions, bgp_asn, bgp_peers_with_range) = parse_cpg(child, asic_name)
@@ -708,7 +700,6 @@ def parse_xml(filename, hostname, asic_name=None):
708700
results['minigraph_mgmt'] = get_mgmt_info(devices, mgmt_dev, mgmt_port)
709701
results['syslog_servers'] = syslog_servers
710702
results['dhcp_servers'] = dhcp_servers
711-
results['dhcpv6_servers'] = dhcpv6_servers
712703
results['ntp_servers'] = ntp_servers
713704
results['forced_mgmt_routes'] = mgmt_routes
714705
results['deployment_id'] = deployment_id

ansible/roles/test/files/ptftests/dhcpv6_relay_test.py

-306
This file was deleted.

ansible/templates/minigraph_dpg.j2

-2
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,6 @@
130130
{% endif %}
131131
{% set dhcp_servers_str=';'.join(dhcp_servers) %}
132132
<DhcpRelays>{{ dhcp_servers_str }}</DhcpRelays>
133-
{% set dhcpv6_servers_str=';'.join(dhcpv6_servers) %}
134-
<Dhcpv6Relays>{{ dhcpv6_servers_str }}</Dhcpv6Relays>
135133
<VlanID>{{ vlan_param['id'] }}</VlanID>
136134
<Tag>{{ vlan_param['tag'] }}</Tag>
137135
<Subnets>{{ vlan_param['prefix'] | ipaddr('network') }}/{{ vlan_param['prefix'] | ipaddr('prefix') }}</Subnets>

0 commit comments

Comments
 (0)