Fix api query when unspecified api passed

kcudnik · kcudnik · commit e7e1d802ac0b · 2021-08-23T19:19:36.000+02:00
diff --git a/lib/sai_redis_interfacequery.cpp b/lib/sai_redis_interfacequery.cpp
@@ -95,6 +95,13 @@ sai_status_t sai_api_query(
         return SAI_STATUS_INVALID_PARAMETER;
     }
 
+    if (sai_api_id == SAI_API_UNSPECIFIED)
+    {
+        SWSS_LOG_ERROR("api ID is unspecified api");
+
+        return SAI_STATUS_INVALID_PARAMETER;
+    }
+
     if (sai_metadata_get_enum_value_name(&sai_metadata_enum_sai_api_t, sai_api_id))
     {
         *api_method_table = ((void**)&redis_apis)[sai_api_id - 1];
diff --git a/vslib/sai_vs_interfacequery.cpp b/vslib/sai_vs_interfacequery.cpp
@@ -92,6 +92,13 @@ sai_status_t sai_api_query(
         return SAI_STATUS_INVALID_PARAMETER;
     }
 
+    if (sai_api_id == SAI_API_UNSPECIFIED)
+    {
+        SWSS_LOG_ERROR("api ID is unspecified api");
+
+        return SAI_STATUS_INVALID_PARAMETER;
+    }
+
     if (sai_metadata_get_enum_value_name(&sai_metadata_enum_sai_api_t, sai_api_id))
     {
         *api_method_table = ((void**)&vs_apis)[sai_api_id - 1];

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,13 @@ sai_status_t sai_api_query(`
`95`	`95`	`return SAI_STATUS_INVALID_PARAMETER;`
`96`	`96`	`}`
`97`	`97`
	`98`	`+ if (sai_api_id == SAI_API_UNSPECIFIED)`
	`99`	`+ {`
	`100`	`+ SWSS_LOG_ERROR("api ID is unspecified api");`
	`101`	`+`
	`102`	`+ return SAI_STATUS_INVALID_PARAMETER;`
	`103`	`+ }`
	`104`	`+`
`98`	`105`	`if (sai_metadata_get_enum_value_name(&sai_metadata_enum_sai_api_t, sai_api_id))`
`99`	`106`	`{`
`100`	`107`	`api_method_table = ((void*)&redis_apis)[sai_api_id - 1];`
Original file line number	Diff line number	Diff line change
`@@ -92,6 +92,13 @@ sai_status_t sai_api_query(`
`92`	`92`	`return SAI_STATUS_INVALID_PARAMETER;`
`93`	`93`	`}`
`94`	`94`
	`95`	`+ if (sai_api_id == SAI_API_UNSPECIFIED)`
	`96`	`+ {`
	`97`	`+ SWSS_LOG_ERROR("api ID is unspecified api");`
	`98`	`+`
	`99`	`+ return SAI_STATUS_INVALID_PARAMETER;`
	`100`	`+ }`
	`101`	`+`
`95`	`102`	`if (sai_metadata_get_enum_value_name(&sai_metadata_enum_sai_api_t, sai_api_id))`
`96`	`103`	`{`
`97`	`104`	`api_method_table = ((void*)&vs_apis)[sai_api_id - 1];`