Skip to content

Commit c41cbc8

Browse files
authored
Revert "[SAI PTF][202205]Support sai ptf v2 Syncd-rpc (#12763)" (#12785)
This reverts commit 99c01b5.
1 parent c086987 commit c41cbc8

File tree

4 files changed

+4
-29
lines changed

4 files changed

+4
-29
lines changed

platform/broadcom/docker-saiserver-brcm.mk

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
DOCKER_SAISERVER_BRCM = docker-saiserver$(SAITHRIFT_VER)-brcm.gz
44
$(DOCKER_SAISERVER_BRCM)_PATH = $(PLATFORM_PATH)/docker-saiserver-brcm
5-
$(DOCKER_SAISERVER_BRCM)_DEPENDS += $(SAISERVER) $(SAISERVER_DBG)
5+
$(DOCKER_SAISERVER_BRCM)_DEPENDS += $(SAISERVER)
66
$(DOCKER_SAISERVER_BRCM)_FILES += $(DSSERVE) $(BCMCMD)
77
$(DOCKER_SAISERVER_BRCM)_LOAD_DOCKERS += $(DOCKER_CONFIG_ENGINE_BULLSEYE)
88
SONIC_DOCKER_IMAGES += $(DOCKER_SAISERVER_BRCM)
+2-20
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,21 @@
11
# docker image for brcm syncd with rpc
22

3-
DOCKER_SYNCD_BRCM_RPC = docker-syncd-brcm-rpc$(SAITHRIFT_VER).gz
4-
DOCKER_SYNCD_BRCM_RPC_DBG = docker-syncd-brcm-rpc$(SAITHRIFT_VER)-$(DBG_IMAGE_MARK).gz
3+
DOCKER_SYNCD_BRCM_RPC = docker-syncd-brcm-rpc.gz
54
$(DOCKER_SYNCD_BRCM_RPC)_PATH = $(PLATFORM_PATH)/docker-syncd-brcm-rpc
6-
7-
8-
#Support two different versions of thrift
9-
ifeq ($(SAITHRIFT_V2),y)
10-
$(DOCKER_SYNCD_BRCM_RPC)_DEPENDS += $(SYNCD_RPC) $(LIBTHRIFT_0_14_1) $(LIBTHRIFT_0_14_1_DEV) $(PYTHON3_THRIFT_0_14_1) $(THRIFT_0_14_1_COMPILER) $(PTF)
11-
else
125
$(DOCKER_SYNCD_BRCM_RPC)_DEPENDS += $(SYNCD_RPC) $(LIBTHRIFT) $(PTF)
13-
endif
14-
156
ifeq ($(INSTALL_DEBUG_TOOLS), y)
167
$(DOCKER_SYNCD_BRCM_RPC)_DEPENDS += $(SYNCD_RPC_DBG) \
178
$(LIBSWSSCOMMON_DBG) \
189
$(LIBSAIMETADATA_DBG) \
1910
$(LIBSAIREDIS_DBG)
2011
endif
2112
$(DOCKER_SYNCD_BRCM_RPC)_FILES += $(DSSERVE) $(BCMCMD) $(SUPERVISOR_PROC_EXIT_LISTENER_SCRIPT)
22-
2313
$(DOCKER_SYNCD_BRCM_RPC)_LOAD_DOCKERS += $(DOCKER_SYNCD_BASE)
24-
$(DOCKER_SYNCD_BRCM_RPC)_DBG_DEPENDS += $($(DOCKER_CONFIG_ENGINE_BULLSEYE)_DBG_DEPENDS)
25-
$(DOCKER_SYNCD_BRCM_RPC)_DBG_IMAGE_PACKAGES = $($(DOCKER_CONFIG_ENGINE_BULLSEYE)_DBG_IMAGE_PACKAGES)
26-
2714
SONIC_DOCKER_IMAGES += $(DOCKER_SYNCD_BRCM_RPC)
2815
ifeq ($(ENABLE_SYNCD_RPC),y)
2916
SONIC_INSTALL_DOCKER_IMAGES += $(DOCKER_SYNCD_BRCM_RPC)
3017
endif
3118

32-
SONIC_DOCKER_DBG_IMAGES += $(DOCKER_SYNCD_BRCM_RPC_DBG)
33-
ifneq ($(ENABLE_SYNCD_RPC),y)
34-
SONIC_INSTALL_DOCKER_DBG_IMAGES += $(DOCKER_SYNCD_BRCM_RPC_DBG)
35-
endif
36-
3719
$(DOCKER_SYNCD_BRCM_RPC)_CONTAINER_NAME = syncd
3820
$(DOCKER_SYNCD_BRCM_RPC)_VERSION = 1.0.0+rpc
3921
$(DOCKER_SYNCD_BRCM_RPC)_PACKAGE_NAME = syncd
@@ -42,9 +24,9 @@ $(DOCKER_SYNCD_BRCM_RPC)_RUN_OPT += -v /host/machine.conf:/etc/machine.conf
4224
$(DOCKER_SYNCD_BRCM_RPC)_RUN_OPT += -v /host/warmboot:/var/warmboot
4325
$(DOCKER_SYNCD_BRCM_RPC)_RUN_OPT += -v /var/run/docker-syncd:/var/run/sswsyncd
4426
$(DOCKER_SYNCD_BRCM_RPC)_RUN_OPT += -v /etc/sonic:/etc/sonic:ro
27+
4528
$(DOCKER_SYNCD_BRCM_RPC)_BASE_IMAGE_FILES += bcmcmd:/usr/bin/bcmcmd
4629
$(DOCKER_SYNCD_BRCM_RPC)_BASE_IMAGE_FILES += bcmsh:/usr/bin/bcmsh
4730
$(DOCKER_SYNCD_BRCM_RPC)_MACHINE = broadcom
4831

4932
SONIC_BULLSEYE_DOCKERS += $(DOCKER_SYNCD_BRCM_RPC)
50-
SONIC_BULLSEYE_DBG_DOCKERS += $(DOCKER_SYNCD_BRCM_RPC_DBG)

platform/broadcom/docker-syncd-brcm-rpc/Dockerfile.j2

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ RUN apt-get update \
2525
cmake \
2626
libqt5core5a \
2727
libqt5network5 \
28-
gdb \
2928
libboost-atomic1.74.0
3029

3130
RUN dpkg_apt() { [ -f $1 ] && { dpkg -i $1 || apt-get -y install -f; } || return 1; } ; \

rules/syncd.mk

+1-7
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,7 @@ $(SYNCD_RPC)_RDEPENDS += $(LIBSAIREDIS) $(LIBSAIMETADATA)
1717
$(eval $(call add_derived_package,$(SYNCD),$(SYNCD_RPC)))
1818

1919
# Inject libthrift build dependency for RPC build
20-
# Support two different versions of thrift
21-
ifeq ($(SAITHRIFT_V2),y)
22-
$(SYNCD)_DEPENDS += $(LIBTHRIFT_0_14_1_DEV)
23-
else
24-
$(SYNCD)_DEPENDS += $(LIBTHRIFT_DEV)
25-
endif
26-
$(SYNCD)_DEPENDS += $(LIBSWSSCOMMON_DEV)
20+
$(SYNCD)_DEPENDS += $(LIBSWSSCOMMON_DEV) $(LIBTHRIFT_DEV)
2721
$(SYNCD)_DPKG_TARGET = binary-syncd-rpc
2822
endif
2923

0 commit comments

Comments
 (0)