Skip to content

Commit c40e43a

Browse files
brandonchuanglguohan
authored andcommitted
[device/accton] Fix accton driver not been installed (#6327)
Accton util applies lsmod to check if drivers are installed. But lsmod may return error on startup and skip module installation. Signed-off-by: Brandon Chuang <[email protected]>
1 parent 29562d0 commit c40e43a

File tree

17 files changed

+75
-51
lines changed

17 files changed

+75
-51
lines changed

platform/broadcom/sonic-platform-modules-accton/as5712-54x/utils/accton_as5712_util.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -240,11 +240,12 @@ def log_os_system(cmd, show):
240240
return status, output
241241

242242
def driver_inserted():
243-
ret, lsmod = log_os_system("ls /sys/module/ | grep accton", 0)
243+
ret, lsmod = log_os_system("ls /sys/module/*accton*", 0)
244244
logging.info('mods:'+lsmod)
245-
if not lsmod:
245+
if ret :
246246
return False
247-
247+
else :
248+
return True
248249

249250
kos = [
250251
'depmod -ae',

platform/broadcom/sonic-platform-modules-accton/as5812-54t/utils/accton_as5812_util.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,12 @@ def log_os_system(cmd, show):
145145
return status, output
146146

147147
def driver_check():
148-
ret, lsmod = log_os_system("lsmod| grep accton", 0)
148+
ret, lsmod = log_os_system("ls /sys/module/*accton*", 0)
149149
logging.info('mods:'+lsmod)
150-
if len(lsmod) ==0:
151-
return False
152-
return True
150+
if ret :
151+
return False
152+
else :
153+
return True
153154

154155
kos = [
155156
'modprobe i2c_dev',

platform/broadcom/sonic-platform-modules-accton/as5812-54x/utils/accton_as5812_util.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -240,10 +240,12 @@ def log_os_system(cmd, show):
240240
return status, output
241241

242242
def driver_inserted():
243-
ret, lsmod = log_os_system("ls /sys/module | grep accton", 0)
243+
ret, lsmod = log_os_system("ls /sys/module/*accton*", 0)
244244
logging.info('mods:'+lsmod)
245-
if len(lsmod) ==0:
245+
if ret :
246246
return False
247+
else :
248+
return True
247249

248250

249251

platform/broadcom/sonic-platform-modules-accton/as5835-54t/utils/accton_as5835_54t_util.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,12 @@ def log_os_system(cmd, show):
145145
return status, output
146146

147147
def driver_check():
148-
ret, lsmod = log_os_system("lsmod| grep accton", 0)
148+
ret, lsmod = log_os_system("ls /sys/module/*accton*", 0)
149149
logging.info('mods:'+lsmod)
150-
if len(lsmod) ==0:
151-
return False
152-
return True
150+
if ret :
151+
return False
152+
else :
153+
return True
153154

154155

155156

platform/broadcom/sonic-platform-modules-accton/as5835-54x/utils/accton_as5835_54x_util.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,12 @@ def log_os_system(cmd, show):
145145
return status, output
146146

147147
def driver_check():
148-
ret, lsmod = log_os_system("ls /sys/module/ | grep accton", 0)
148+
ret, lsmod = log_os_system("ls /sys/module/*accton*", 0)
149149
logging.info('mods:'+lsmod)
150-
if len(lsmod) ==0:
150+
if ret :
151151
return False
152-
return True
152+
else :
153+
return True
153154

154155

155156

platform/broadcom/sonic-platform-modules-accton/as6712-32x/utils/accton_as6712_util.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -249,10 +249,12 @@ def log_os_system(cmd, show):
249249
return status, output
250250

251251
def driver_inserted():
252-
ret, lsmod = log_os_system("lsmod| grep accton", 0)
252+
ret, lsmod = log_os_system("ls /sys/module/*accton*", 0)
253253
logging.info('mods:'+lsmod)
254-
if len(lsmod) ==0:
254+
if ret :
255255
return False
256+
else :
257+
return True
256258

257259

258260

platform/broadcom/sonic-platform-modules-accton/as7312-54x/utils/accton_as7312_util.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -150,11 +150,12 @@ def log_os_system(cmd, show):
150150

151151

152152
def driver_check():
153-
(ret, lsmod) = log_os_system('ls /sys/module/ | grep accton', 0)
154-
logging.info('mods:' + lsmod)
155-
if not lsmod:
153+
ret, lsmod = log_os_system("ls /sys/module/*accton*", 0)
154+
logging.info('mods:'+lsmod)
155+
if ret :
156156
return False
157-
return True
157+
else :
158+
return True
158159

159160

160161
kos = [

platform/broadcom/sonic-platform-modules-accton/as7312-54xs/utils/accton_as7312_util.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,12 @@ def log_os_system(cmd, show):
145145
return status, output
146146

147147
def driver_check():
148-
ret, lsmod = log_os_system("lsmod| grep accton", 0)
148+
ret, lsmod = log_os_system("ls /sys/module/*accton*", 0)
149149
logging.info('mods:'+lsmod)
150-
if len(lsmod) ==0:
151-
return False
152-
return True
150+
if ret :
151+
return False
152+
else :
153+
return True
153154

154155

155156

platform/broadcom/sonic-platform-modules-accton/as7315-27xb/utils/accton_as7315_util.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -147,11 +147,12 @@ def log_os_system(cmd, show):
147147
return status, output
148148

149149
def driver_check():
150-
ret, lsmod = log_os_system("lsmod| grep accton", 0)
150+
ret, lsmod = log_os_system("ls /sys/module/*accton*", 0)
151151
logging.info('mods:'+lsmod)
152-
if len(lsmod) ==0:
153-
return False
154-
return True
152+
if ret :
153+
return False
154+
else :
155+
return True
155156

156157

157158

platform/broadcom/sonic-platform-modules-accton/as7326-56x/utils/accton_as7326_util.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,12 @@ def log_os_system(cmd, show):
178178
return status, output
179179

180180
def driver_check():
181-
ret, lsmod = log_os_system("lsmod| grep accton", 0)
181+
ret, lsmod = log_os_system("ls /sys/module/*accton*", 0)
182182
logging.info('mods:'+lsmod)
183-
if len(lsmod) ==0:
183+
if ret :
184184
return False
185-
return True
185+
else :
186+
return True
186187

187188

188189

platform/broadcom/sonic-platform-modules-accton/as7712-32x/utils/accton_as7712_util.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,12 @@ def log_os_system(cmd, show):
145145
return status, output
146146

147147
def driver_check():
148-
ret, lsmod = log_os_system("lsmod| grep accton", 0)
148+
ret, lsmod = log_os_system("ls /sys/module/*accton*", 0)
149149
logging.info('mods:'+lsmod)
150-
if len(lsmod) ==0:
151-
return False
152-
return True
150+
if ret :
151+
return False
152+
else :
153+
return True
153154

154155

155156

platform/broadcom/sonic-platform-modules-accton/as7716-32x/utils/accton_as7716_util.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -267,10 +267,12 @@ def log_os_system(cmd, show):
267267
return status, output
268268

269269
def driver_inserted():
270-
ret, lsmod = log_os_system("lsmod| grep accton", 0)
270+
ret, lsmod = log_os_system("ls /sys/module/*accton*", 0)
271271
logging.info('mods:'+lsmod)
272-
if len(lsmod) ==0:
272+
if ret :
273273
return False
274+
else :
275+
return True
274276

275277
#'modprobe cpr_4011_4mxx',
276278

platform/broadcom/sonic-platform-modules-accton/as7716-32xb/utils/accton_as7716_32xb_util.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -240,10 +240,12 @@ def log_os_system(cmd, show):
240240
return status, output
241241

242242
def driver_inserted():
243-
ret, lsmod = log_os_system("lsmod| grep accton", 0)
243+
ret, lsmod = log_os_system("ls /sys/module/*accton*", 0)
244244
logging.info('mods:'+lsmod)
245-
if len(lsmod) ==0:
245+
if ret :
246246
return False
247+
else :
248+
return True
247249

248250

249251
kos = [

platform/broadcom/sonic-platform-modules-accton/as7726-32x/utils/accton_as7726_32x_util.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -248,10 +248,12 @@ def log_os_system(cmd, show):
248248
return status, output
249249

250250
def driver_inserted():
251-
ret, lsmod = log_os_system("lsmod| grep accton", 0)
251+
ret, lsmod = log_os_system("ls /sys/module/*accton*", 0)
252252
logging.info('mods:'+lsmod)
253-
if len(lsmod) ==0:
253+
if ret :
254254
return False
255+
else :
256+
return True
255257

256258
def cpld_reset_mac():
257259
ret, lsmod = log_os_system("i2cset -y 0 0x77 0x1", 0)

platform/broadcom/sonic-platform-modules-accton/as7816-64x/utils/accton_as7816_util.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -167,11 +167,12 @@ def log_os_system(cmd, show):
167167
return status, output
168168

169169
def driver_check():
170-
ret, lsmod = log_os_system("lsmod| grep accton", 0)
170+
ret, lsmod = log_os_system("ls /sys/module/*accton*", 0)
171171
logging.info('mods:'+lsmod)
172-
if len(lsmod) ==0:
173-
return False
174-
return True
172+
if ret :
173+
return False
174+
else :
175+
return True
175176

176177

177178

platform/broadcom/sonic-platform-modules-accton/as9716-32d/utils/accton_as9716_32d_util.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -254,10 +254,12 @@ def log_os_system(cmd, show):
254254
return status, output
255255

256256
def driver_inserted():
257-
ret, lsmod = log_os_system("lsmod| grep accton", 0)
257+
ret, lsmod = log_os_system("ls /sys/module/*accton*", 0)
258258
logging.info('mods:'+lsmod)
259-
if len(lsmod) ==0:
259+
if ret :
260260
return False
261+
else :
262+
return True
261263

262264

263265
kos = [

platform/broadcom/sonic-platform-modules-accton/minipack/utils/accton_minipack_util.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -181,10 +181,12 @@ def log_os_system(cmd, show):
181181
return status, output
182182

183183
def driver_inserted():
184-
ret, lsmod = log_os_system("lsmod| grep accton", 0)
184+
ret, lsmod = log_os_system("ls /sys/module/*accton*", 0)
185185
logging.info('mods:'+lsmod)
186-
if len(lsmod) ==0:
186+
if ret :
187187
return False
188+
else :
189+
return True
188190

189191

190192

0 commit comments

Comments
 (0)