Skip to content

Commit c35ec09

Browse files
committed
Remove run
Signed-off-by: maipbui <[email protected]>
1 parent 1e62cff commit c35ec09

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

device/mellanox/x86_64-mlnx_msn2700-r0/plugins/sfputil.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ def get_low_power_mode(self, port_num):
158158
lpm_cmd = ["docker", "exec", "syncd", "python", "/usr/share/sonic/platform/plugins/sfplpmget.py", str(port_num)]
159159

160160
try:
161-
output = subprocess.run(lpm_cmd, universal_newlines=True, capture_output=True, check=True).stdout
161+
output = subprocess.check_output(lpm_cmd, universal_newlines=True)
162162
if 'LPM ON' in output:
163163
return True
164164
except subprocess.CalledProcessError as e:
@@ -182,7 +182,7 @@ def set_low_power_mode(self, port_num, lpmode):
182182

183183
# Set LPM
184184
try:
185-
subprocess.run(lpm_cmd, check=True, universal_newlines=True, capture_output=True).stdout
185+
subprocess.check_output(lpm_cmd, universal_newlines=True)
186186
except subprocess.CalledProcessError as e:
187187
print("Error! Unable to set LPM for {}, rc = {}, err msg: {}".format(port_num, e.returncode, e.output))
188188
return False
@@ -197,7 +197,7 @@ def reset(self, port_num):
197197
lpm_cmd = ["docker", "exec", "syncd", "python", "/usr/share/sonic/platform/plugins/sfpreset.py", str(port_num)]
198198

199199
try:
200-
subprocess.run(lpm_cmd, check=True, universal_newlines=True, capture_output=True).stdout
200+
subprocess.check_output(lpm_cmd, universal_newlines=True)
201201
return True
202202
except subprocess.CalledProcessError as e:
203203
print("Error! Unable to set LPM for {}, rc = {}, err msg: {}".format(port_num, e.returncode, e.output))
@@ -269,7 +269,7 @@ def _read_eeprom_specific_bytes_via_ethtool(self, port_num, offset, num_bytes):
269269
eeprom_raw = []
270270
ethtool_cmd = ["ethtool", "-m", sfpname, "hex", "on", "offset", str(offset), "length", str(num_bytes)]
271271
try:
272-
output = subprocess.run(ethtool_cmd, check=True, universal_newlines=True, capture_output=True).stdout
272+
output = subprocess.check_output(ethtool_cmd, universal_newlines=True)
273273
output_lines = output.splitlines()
274274
first_line_raw = output_lines[0]
275275
if "Offset" in first_line_raw:

platform/mellanox/mlnx-platform-api/tests/test_chassis.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -276,12 +276,12 @@ def test_revision_permission(self):
276276
#Override the dmi file
277277
sonic_platform.chassis.DMI_FILE = "/tmp/dmi_file"
278278
new_dmi_file = sonic_platform.chassis.DMI_FILE
279-
subprocess.run(["touch", new_dmi_file])
280-
subprocess.run(["chmod", "-r", new_dmi_file])
279+
subprocess.call(["touch", new_dmi_file])
280+
subprocess.call(["chmod", "-r", new_dmi_file])
281281
chassis = Chassis()
282282
rev = chassis.get_revision()
283283
sonic_platform.chassis.DMI_FILE = old_dmi_file
284-
subprocess.run(["rm", "-f", new_dmi_file])
284+
subprocess.call(["rm", "-f", new_dmi_file])
285285
assert rev == "N/A"
286286

287287
def test_get_port_or_cage_type(self):

0 commit comments

Comments
 (0)