Skip to content

Commit b163ae0

Browse files
Fix LGTM warning
1 parent d70896e commit b163ae0

File tree

9 files changed

+3
-14
lines changed

9 files changed

+3
-14
lines changed

platform/mellanox/mlnx-platform-api/sonic_platform/chassis.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@
99
try:
1010
from sonic_platform_base.chassis_base import ChassisBase
1111
from sonic_py_common.logger import Logger
12-
import glob
1312
import os
14-
import sys
1513
from functools import reduce
1614

1715
from . import utils
@@ -794,7 +792,7 @@ def get_module(self, index):
794792
module
795793
"""
796794
self.initialize_single_module(index)
797-
return super(Chassis, self).get_module(index)
795+
return super(ModularChassis, self).get_module(index)
798796

799797
@utils.default_return(-1)
800798
def get_module_index(self, module_name):

platform/mellanox/mlnx-platform-api/sonic_platform/eeprom.py

-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
#############################################################################
88
import os
99
import subprocess
10-
import time
11-
import subprocess
1210

1311
from sonic_py_common.logger import Logger
1412
try:

platform/mellanox/mlnx-platform-api/sonic_platform/fan.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
try:
1313
from sonic_platform_base.fan_base import FanBase
1414
from sonic_py_common.logger import Logger
15-
from .led import FanLed, ComponentFaultyIndicator
15+
from .led import ComponentFaultyIndicator
1616
from . import utils
1717
except ImportError as e:
1818
raise ImportError (str(e) + "- required module not found")

platform/mellanox/mlnx-platform-api/sonic_platform/module.py

-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
import os
21
import redis
3-
import sys
42
import threading
53
from sonic_platform_base.module_base import ModuleBase
64
from sonic_py_common.logger import Logger

platform/mellanox/mlnx-platform-api/tests/test_eeprom.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def test_chassis_eeprom(self, mock_eeprom_info):
3535
def test_eeprom_init(self):
3636
# Test symlink not exist, there is an exception
3737
with pytest.raises(RuntimeError):
38-
eeprom = Eeprom()
38+
Eeprom()
3939

4040
@patch('os.path.exists', MagicMock(return_value=True))
4141
@patch('os.path.islink', MagicMock(return_value=True))

platform/mellanox/mlnx-platform-api/tests/test_fan_api.py

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
from sonic_platform import utils
1212
from sonic_platform.fan import Fan, PsuFan, COOLING_STATE_PATH
13-
from sonic_platform.led import FanLed
1413
from sonic_platform.fan_drawer import RealDrawer, VirtualDrawer
1514
from sonic_platform.psu import Psu
1615

platform/mellanox/mlnx-platform-api/tests/test_psu.py

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
from sonic_platform import utils
1313
from sonic_platform.psu import FixedPsu, Psu
14-
from sonic_platform.device_data import DeviceDataManager
1514

1615

1716
class TestPsu:

platform/mellanox/mlnx-platform-api/tests/test_sfp_event.py

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import os
2-
import select
32
import sys
43

54
from mock import MagicMock, patch

platform/mellanox/mlnx-platform-api/tests/test_thermal.py

-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import glob
22
import os
3-
import pytest
4-
import shutil
53
import sys
64
if sys.version_info.major == 3:
75
from unittest import mock

0 commit comments

Comments
 (0)