Skip to content

Commit 84a8b0d

Browse files
author
Shuotian Cheng
authored
[minigraph]: Fix a bug of minigraph_neighbors (#485)
Signed-off-by: Shuotian Cheng <[email protected]>
1 parent eef859b commit 84a8b0d

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/sonic-config-engine/minigraph.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def parse_png(png, hname):
7373
neighbors[endport] = {'name': startdevice, 'port': startport}
7474
else:
7575
if port_alias_map.has_key(startport):
76-
endport = port_alias_map[startport]
76+
startport = port_alias_map[startport]
7777
neighbors[startport] = {'name': enddevice, 'port': endport}
7878

7979
if child.tag == str(QName(ns, "Devices")):

src/sonic-config-engine/tests/test_cfggen.py

+4
Original file line numberDiff line numberDiff line change
@@ -87,3 +87,7 @@ def test_minigraph_portchannels(self):
8787
output = self.run_script(argument)
8888
self.assertEqual(output.strip(), "[{'subnet': IPv4Network('10.0.0.56/31'), 'peer_addr': IPv4Address('10.0.0.57'), 'addr': IPv4Address('10.0.0.56'), 'mask': IPv4Address('255.255.255.254'), 'attachto': 'PortChannel01', 'prefixlen': 31}, {'subnet': IPv6Network('fc00::70/126'), 'peer_addr': IPv6Address('fc00::72'), 'addr': IPv6Address('fc00::71'), 'mask': '126', 'attachto': 'PortChannel01', 'prefixlen': 126}]")
8989

90+
def test_minigraph_neighbors(self):
91+
argument = '-m "' + self.sample_graph_t0 + '" -p "' + self.port_config + '" -v minigraph_neighbors'
92+
output = self.run_script(argument)
93+
self.assertEqual(output.strip(), "{'Ethernet116': {'name': 'ARISTA02T1', 'port': 'Ethernet1/1'}, 'Ethernet124': {'name': 'ARISTA04T1', 'port': 'Ethernet1/1'}, 'Ethernet112': {'name': 'ARISTA01T1', 'port': 'Ethernet1/1'}, 'Ethernet120': {'name': 'ARISTA03T1', 'port': 'Ethernet1/1'}}")

0 commit comments

Comments
 (0)