Skip to content

Commit 763205f

Browse files
Volodymyr Samotiylguohan
authored andcommitted
[config]: Fix management interface configuration (#966)
* [config]: Fix management interface configuration * [config]: Fix management interface configuration * Fix comments
1 parent d117f09 commit 763205f

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

files/image_config/interfaces/interfaces.j2

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@ iface eth0 {{ 'inet' if prefix | ipv4 else 'inet6' }} static
2727
netmask {{ prefix | netmask if prefix | ipv4 else prefix | prefixlen }}
2828
########## management network policy routing rules
2929
# management port up rules
30-
up ip route add default via {{ MGMT_INTERFACE[(name, prefix)]['gwaddr'] }} dev eth0 table default
31-
up ip rule add from {{ prefix | ip }}/32 table default
30+
up ip {{ '-4' if prefix | ipv4 else '-6' }} route add default via {{ MGMT_INTERFACE[(name, prefix)]['gwaddr'] }} dev eth0 table default
31+
up ip {{ '-4' if prefix | ipv4 else '-6' }} rule add from {{ prefix | ip }}/{{ '32' if prefix | ipv4 else '128' }} table default
3232
{% for route in MGMT_INTERFACE[(name, prefix)]['forced_mgmt_routes'] %}
3333
up ip rule add to {{ route }} table default
3434
{% endfor %}
3535
# management port down rules
36-
down ip route delete default via {{ MGMT_INTERFACE[(name, prefix)]['gwaddr'] }} dev eth0 table default
37-
down ip rule delete from {{ prefix | ip }}/32 table default
36+
down ip {{ '-4' if prefix | ipv4 else '-6' }} route delete default via {{ MGMT_INTERFACE[(name, prefix)]['gwaddr'] }} dev eth0 table default
37+
down ip {{ '-4' if prefix | ipv4 else '-6' }} rule delete from {{ prefix | ip }}/{{ '32' if prefix | ipv4 else '128' }} table default
3838
{% for route in MGMT_INTERFACE[(name, prefix)]['forced_mgmt_routes'] %}
3939
down ip rule delete to {{ route }} table default
4040
{% endfor %}

src/sonic-config-engine/tests/sample_output/interfaces

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,21 @@ iface eth0 inet static
2222
netmask 255.255.255.0
2323
########## management network policy routing rules
2424
# management port up rules
25-
up ip route add default via 10.0.0.1 dev eth0 table default
26-
up ip rule add from 10.0.0.100/32 table default
25+
up ip -4 route add default via 10.0.0.1 dev eth0 table default
26+
up ip -4 rule add from 10.0.0.100/32 table default
2727
# management port down rules
28-
down ip route delete default via 10.0.0.1 dev eth0 table default
29-
down ip rule delete from 10.0.0.100/32 table default
28+
down ip -4 route delete default via 10.0.0.1 dev eth0 table default
29+
down ip -4 rule delete from 10.0.0.100/32 table default
3030
iface eth0 inet6 static
3131
address 2603:10e2:0:2902::8
3232
netmask 64
3333
########## management network policy routing rules
3434
# management port up rules
35-
up ip route add default via 2603:10e2:0:2902::1 dev eth0 table default
36-
up ip rule add from 2603:10e2:0:2902::8/32 table default
35+
up ip -6 route add default via 2603:10e2:0:2902::1 dev eth0 table default
36+
up ip -6 rule add from 2603:10e2:0:2902::8/128 table default
3737
# management port down rules
38-
down ip route delete default via 2603:10e2:0:2902::1 dev eth0 table default
39-
down ip rule delete from 2603:10e2:0:2902::8/32 table default
38+
down ip -6 route delete default via 2603:10e2:0:2902::1 dev eth0 table default
39+
down ip -6 rule delete from 2603:10e2:0:2902::8/128 table default
4040
#
4141
# The switch front panel interfaces
4242
# "|| true" is added to suppress the error when interface is already a member of VLAN

0 commit comments

Comments
 (0)