Skip to content

Commit 6153602

Browse files
authored
[build]: Fix docker load image tag not being the expected tag (#12959)
PR #12829 modified the docker tagging scheme such that optional docker containers would be tagged with the SONiC image version. However, the docker-image-load macro wasn't updated for these changes. Update it here. Signed-off-by: Saikrishna Arcot <[email protected]>
1 parent 19ec89b commit 6153602

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

slave.mk

+3-3
Original file line numberDiff line numberDiff line change
@@ -498,11 +498,11 @@ define docker-image-load
498498
@echo "Obtained docker image lock for $(1) load" $(LOG)
499499
@echo "Loading docker image $(TARGET_PATH)/$(1).gz" $(LOG)
500500
docker load -i $(TARGET_PATH)/$(1).gz $(LOG)
501-
@echo "Tagging docker image $(1):latest as $(1)-$(DOCKER_USERNAME):$(DOCKER_USERTAG)" $(LOG)
502-
docker tag $(1):latest $(1)-$(DOCKER_USERNAME):$(DOCKER_USERTAG) $(LOG)
501+
@echo "Tagging docker image $(1):$(call docker-get-tag,$(1)) as $(1)-$(DOCKER_USERNAME):$(DOCKER_USERTAG)" $(LOG)
502+
docker tag $(1):$(call docker-get-tag,$(1)) $(1)-$(DOCKER_USERNAME):$(DOCKER_USERTAG) $(LOG)
503503
if [ x$(SONIC_CONFIG_USE_NATIVE_DOCKERD_FOR_BUILD) == x"y" ]; then
504504
@echo "Removing docker image $(1):latest" $(LOG)
505-
docker rmi -f $(1):latest $(LOG)
505+
docker rmi -f $(1):$(call docker-get-tag,$(1)) $(LOG)
506506
fi
507507
$(call MOD_UNLOCK,$(1))
508508
@echo "Released docker image lock for $(1) load" $(LOG)

0 commit comments

Comments
 (0)