Skip to content

Commit 5982f5e

Browse files
Improve the display of pipeline. (#13125)
The display of azure pipeline is not specific now, such as when the step Run test fails, the display of itself shows successful, but the display of step Kvmdump shows fails, but actually, the step Kvmdump doesn't fail. I improve the display of azure pipeline in this pr, each step has its own success or failure, and is shown in azure pipeline. Why I did it The display of azure pipeline is not specific now, such as when the step Run test fails, the display of itself shows successful, but the display of step Kvmdump shows fails, but actually, the step Kvmdump doesn't fail. I improve the display of azure pipeline in this pr, each step has its own success or failure, and is shown in azure pipeline. How I did it Each step has its own signature of success or failure. Using the chain of responsibility pattern to manage all status. Modify the expected-state in each step.
1 parent 9a06e91 commit 5982f5e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.azure-pipelines/run-test-scheduler-template.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ steps:
7676
echo "TestbedV2 is just online and might not be stable enough, for any issue, please send email to [email protected]"
7777
echo "Runtime detailed progress at https://www.testbed-tools.org/scheduler/testplan/$TEST_PLAN_ID"
7878
# When "LOCK_TESTBED" finish, it changes into "PREPARE_TESTBED"
79-
python ./.azure-pipelines/test_plan.py poll -i "$(TEST_PLAN_ID)" --expected-states PREPARE_TESTBED EXECUTING KVMDUMP FINISHED CANCELLED FAILED
79+
python ./.azure-pipelines/test_plan.py poll -i "$(TEST_PLAN_ID)" --expected-state LOCK_TESTBED
8080
env:
8181
TESTBED_TOOLS_URL: $(TESTBED_TOOLS_URL)
8282
displayName: Lock testbed
@@ -89,7 +89,7 @@ steps:
8989
echo "TestbedV2 is just online and might not be stable enough, for any issue, please send email to [email protected]"
9090
echo "Runtime detailed progress at https://www.testbed-tools.org/scheduler/testplan/$TEST_PLAN_ID"
9191
# When "PREPARE_TESTBED" finish, it changes into "EXECUTING"
92-
python ./.azure-pipelines/test_plan.py poll -i "$(TEST_PLAN_ID)" --expected-states EXECUTING KVMDUMP FINISHED CANCELLED FAILED
92+
python ./.azure-pipelines/test_plan.py poll -i "$(TEST_PLAN_ID)" --expected-state PREPARE_TESTBED
9393
env:
9494
TESTBED_TOOLS_URL: $(TESTBED_TOOLS_URL)
9595
displayName: Prepare testbed
@@ -100,7 +100,7 @@ steps:
100100
echo "TestbedV2 is just online and might not be stable enough, for any issue, please send email to [email protected]"
101101
echo "Runtime detailed progress at https://www.testbed-tools.org/scheduler/testplan/$TEST_PLAN_ID"
102102
# When "EXECUTING" finish, it changes into "KVMDUMP", "FAILED", "CANCELLED" or "FINISHED"
103-
python ./.azure-pipelines/test_plan.py poll -i "$(TEST_PLAN_ID)" --expected-states KVMDUMP FINISHED CANCELLED FAILED
103+
python ./.azure-pipelines/test_plan.py poll -i "$(TEST_PLAN_ID)" --expected-state EXECUTING
104104
env:
105105
TESTBED_TOOLS_URL: $(TESTBED_TOOLS_URL)
106106
displayName: Run test
@@ -111,7 +111,7 @@ steps:
111111
echo "TestbedV2 is just online and might not be stable enough, for any issue, please send email to [email protected]"
112112
echo "Runtime detailed progress at https://www.testbed-tools.org/scheduler/testplan/$TEST_PLAN_ID"
113113
# When "KVMDUMP" finish, it changes into "FAILED", "CANCELLED" or "FINISHED"
114-
python ./.azure-pipelines/test_plan.py poll -i "$(TEST_PLAN_ID)" --expected-states FINISHED CANCELLED FAILED
114+
python ./.azure-pipelines/test_plan.py poll -i "$(TEST_PLAN_ID)" --expected-state KVMDUMP
115115
condition: succeededOrFailed()
116116
env:
117117
TESTBED_TOOLS_URL: $(TESTBED_TOOLS_URL)

0 commit comments

Comments
 (0)