Skip to content

Commit 550cd66

Browse files
Fix sonic slave pipeline to set correct tag on sonic slave image. (#13177)
Why I did it Currently sonic-slave-* tag is confusing. Set correct tag on sonic-slave-* image. Fix job name to fit the build. How I did it build amd image in amd64: sonic-slave-bullseye:cfe29bff67c sonic-slave-bullseye:latest sonic-slave-bullseye:master build armhf image in amd64: sonic-slave-bullseye-march-armhf:33614806dc3 sonic-slave-bullseye-march-armhf:latest sonic-slave-bullseye-march-armhf:master build arm64 image in amd64: sonic-slave-bullseye-march-arm64:f3b1b16c801 sonic-slave-bullseye-march-arm64:latest sonic-slave-bullseye-march-arm64:master build arm64 image in arm64: sonic-slave-bullseye:75cb326c9a7 sonic-slave-bullseye-arm64:latest sonic-slave-bullseye:master build armhf image in armhf: sonic-slave-bullseye:64d178951fc sonic-slave-bullseye-armhf:latest sonic-slave-bullseye:master How to verify it
1 parent 661669c commit 550cd66

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

.azure-pipelines/docker-sonic-slave-template.yml

+5-3
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ parameters:
3535
- sonicbld-armhf
3636

3737
jobs:
38-
- job: Build_${{ parameters.dist }}_${{ parameters.march }}${{ parameters.arch }}
38+
- job: sonic_slave_${{ parameters.dist }}${{ parameters.march }}
3939
timeoutInMinutes: 360
4040
variables:
4141
- template: /.azure-pipelines/template-variables.yml@buildimage
@@ -46,7 +46,6 @@ jobs:
4646
- template: /.azure-pipelines/template-clean-sonic-slave.yml@buildimage
4747
- checkout: self
4848
clean: true
49-
submodules: recursive
5049
- task: Docker@2
5150
displayName: Login to ACR
5251
inputs:
@@ -56,6 +55,9 @@ jobs:
5655
set -ex
5756
image_tag=$(BLDENV=${{ parameters.dist }} make -f Makefile.work showtag PLATFORM=generic PLATFORM_ARCH=${{ parameters.arch }} | grep sonic-slave | tail -n 1)
5857
image_latest=$(echo $(echo $image_tag | awk -F: '{print$1}'):latest)
58+
if echo ${{ parameters.pool }} | grep ${{ parameters.arch }};then
59+
image_latest=$(echo ${image_latest} | sed 's/:/-${{ parameters.arch }}:/')
60+
fi
5961
image_branch=$(echo $(echo $image_tag | awk -F: '{print$1}'):$(Build.SourceBranchName))
6062
docker rmi $image_tag || true
6163
@@ -72,7 +74,7 @@ jobs:
7274
docker push ${REGISTRY_SERVER}/${image_tag}
7375
docker tag ${image_tag} ${REGISTRY_SERVER}/${image_branch}
7476
docker push ${REGISTRY_SERVER}/${image_branch}
75-
if [[ "${{ parameters.arch }}" == "amd64" ]] && [[ "$(Build.SourceBranchName)" == "master" ]];then
77+
if [[ "$(Build.SourceBranchName)" == "master" ]];then
7678
docker tag ${image_tag} ${REGISTRY_SERVER}/${image_latest}
7779
docker push ${REGISTRY_SERVER}/${image_latest}
7880
fi

.azure-pipelines/docker-sonic-slave.yml

+5-3
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ parameters:
5656
default: sonicdev
5757

5858
stages:
59-
- stage: Build
59+
- stage: Build_in_amd64
6060
jobs:
6161
- ${{ each dist in parameters.dists }}:
6262
- ${{ if endswith(variables['Build.DefinitionName'], dist) }}:
@@ -66,7 +66,9 @@ stages:
6666
pool: sonicbld
6767
arch: ${{ arch }}
6868
dist: ${{ dist }}
69-
- stage: Build_march
69+
${{ if ne(arch, 'amd64') }}:
70+
march: _march_${{ arch }}
71+
- stage: Build_native_arm
7072
dependsOn: []
7173
jobs:
7274
- ${{ each dist in parameters.dists }}:
@@ -78,4 +80,4 @@ stages:
7880
pool: sonicbld-${{ arch }}
7981
arch: ${{ arch }}
8082
dist: ${{ dist }}
81-
march: march_
83+
march: _${{ arch }}

0 commit comments

Comments
 (0)