Skip to content

Commit 4e3a0a0

Browse files
Fix typo for midplane APIs. (#196)
In midplane API, default method should be raise NotImplementedError not return NotImplementedError
1 parent fc2e9e2 commit 4e3a0a0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

sonic_platform_base/module_base.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ def get_midplane_ip(self):
451451
A string, the IP-address of the module reachable over the midplane
452452
453453
"""
454-
return NotImplementedError
454+
raise NotImplementedError
455455

456456
def is_midplane_reachable(self):
457457
"""
@@ -461,4 +461,4 @@ def is_midplane_reachable(self):
461461
Returns:
462462
A bool value, should return True if module is reachable via midplane
463463
"""
464-
return NotImplementedError
464+
raise NotImplementedError

0 commit comments

Comments
 (0)